-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(opentelemetry-core,sdk-trace-base,sdk-logs): append exception.cause chain to ATTR_EXCEPTION_STACKTRACE #6634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abhisheksurve45
wants to merge
1
commit into
open-telemetry:main
Choose a base branch
from
abhisheksurve45:feat/exception-cause-stacktrace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| export function buildExceptionCauseChain(cause: unknown): string { | ||
| const visited = new Set<unknown>(); | ||
| let result = ''; | ||
| let current = cause; | ||
| while (current && typeof current === 'object' && !visited.has(current)) { | ||
| visited.add(current); | ||
| const c = current as { stack?: string; cause?: unknown }; | ||
| if (c.stack) { | ||
| result += `\nCaused by: ${c.stack}`; | ||
| } | ||
| current = c.cause; | ||
| } | ||
| return result; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import * as assert from 'assert'; | ||
| import { buildExceptionCauseChain } from '../../src/common/exception'; | ||
|
|
||
| describe('exception', () => { | ||
| describe('#buildExceptionCauseChain', () => { | ||
| it('should return empty string when cause is undefined', () => { | ||
| assert.strictEqual(buildExceptionCauseChain(undefined), ''); | ||
| }); | ||
|
|
||
| it('should return empty string when cause is null', () => { | ||
| assert.strictEqual(buildExceptionCauseChain(null), ''); | ||
| }); | ||
|
|
||
| it('should return empty string when cause is a primitive', () => { | ||
| assert.strictEqual(buildExceptionCauseChain('string cause'), ''); | ||
| assert.strictEqual(buildExceptionCauseChain(42), ''); | ||
| }); | ||
|
|
||
| it('should append cause stack when cause has a stack', () => { | ||
| const cause = new Error('inner error'); | ||
| cause.stack = 'Error: inner error\n at inner:1:1'; | ||
| const result = buildExceptionCauseChain(cause); | ||
| assert.strictEqual( | ||
| result, | ||
| '\nCaused by: Error: inner error\n at inner:1:1' | ||
| ); | ||
| }); | ||
|
|
||
| it('should skip cause silently when cause has no stack', () => { | ||
| const cause = { message: 'no stack here' }; | ||
| const result = buildExceptionCauseChain(cause); | ||
| assert.strictEqual(result, ''); | ||
| }); | ||
|
|
||
| it('should walk a multi-level cause chain', () => { | ||
| const root = new Error('root'); | ||
| root.stack = 'Error: root\n at root:1:1'; | ||
|
|
||
| const mid = new Error('mid'); | ||
| mid.stack = 'Error: mid\n at mid:1:1'; | ||
| (mid as any).cause = root; | ||
|
|
||
| const result = buildExceptionCauseChain(mid); | ||
| assert.strictEqual( | ||
| result, | ||
| '\nCaused by: Error: mid\n at mid:1:1\nCaused by: Error: root\n at root:1:1' | ||
| ); | ||
| }); | ||
|
|
||
| it('should terminate on circular cause references without infinite loop', () => { | ||
| const a: any = new Error('a'); | ||
| a.stack = 'Error: a\n at a:1:1'; | ||
| const b: any = new Error('b'); | ||
| b.stack = 'Error: b\n at b:1:1'; | ||
| a.cause = b; | ||
| b.cause = a; | ||
|
|
||
| const result = buildExceptionCauseChain(a); | ||
| assert.strictEqual( | ||
| result, | ||
| '\nCaused by: Error: a\n at a:1:1\nCaused by: Error: b\n at b:1:1' | ||
| ); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC if we could pass the top error here. The only issue would be that the 1st stack will start with the string
\nCaused by:producing something likewith a couple of changes this function could get the top error and return the whole chain.
I wonder if there is a case where we want to have only the cause chain 🤔