Skip to content

chore(test): add call rule external wrapper test#496

Merged
kakkoyun merged 4 commits into
open-telemetry:mainfrom
txabman42:add-call-rule-external
May 19, 2026
Merged

chore(test): add call rule external wrapper test#496
kakkoyun merged 4 commits into
open-telemetry:mainfrom
txabman42:add-call-rule-external

Conversation

@txabman42
Copy link
Copy Markdown
Contributor

Contributing to #475

@txabman42 txabman42 requested a review from a team as a code owner May 12, 2026 18:29
@github-actions github-actions Bot added the scope:chore Something that needs to be taken care of but not very appealing label May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.30%. Comparing base (0216630) to head (77b860f).

Additional details and impacted files
@@            Coverage Diff            @@
##           main     #496       +/-   ##
=========================================
+ Coverage      0   63.30%   +63.30%     
=========================================
  Files         0       62       +62     
  Lines         0     4796     +4796     
=========================================
+ Hits          0     3036     +3036     
- Misses        0     1509     +1509     
- Partials      0      251      +251     
Flag Coverage Δ
tool 63.30% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@amazingakai amazingakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of this!

Comment thread tool/internal/instrument/testdata/golden/call-rule-external-wrapper/rules.yml Outdated
Copy link
Copy Markdown
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kakkoyun kakkoyun merged commit 2c74fda into open-telemetry:main May 19, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:chore Something that needs to be taken care of but not very appealing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants