fix(tool): refresh matched rules after dependency graph changes#495
fix(tool): refresh matched rules after dependency graph changes#495amazingakai wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
==========================================
- Coverage 62.83% 62.51% -0.33%
==========================================
Files 62 62
Lines 4765 4791 +26
==========================================
+ Hits 2994 2995 +1
- Misses 1527 1552 +25
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This slows down the setup time a bit because it it has run the setup in 2-3 passes now. I will try to investigate this a bit more to see if I missed something that could be optimized but I think this is reasonable. Integration tests on windows are failing due to timeout, we might need to increase the timeout for integration tests |
|
Done. Since first pass always added otel as a dependency, it was trying to instrument that as well which slowed down the build time. |
Description
Matches rules in multiple setup passes to ensure matched rules are refreshed after dependency graph of a project changes
Motivation
Fixes build failures caused by instrumentation dependencies updating the user's dependency graph (via go mod tidy), which could make previously matched rules stale
Fixes #494
Checklist
make formatmake lintmake test