Skip to content

fix(testutil): use polling for TCP readiness checks #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
txabman42 merged 1 commit into from
May 14, 2026
+6 −7
Merged

fix(testutil): use polling for TCP readiness checks #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions test/testutil/readiness.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import (
"net"
"testing"
"time"

"github.com/stretchr/testify/require"
)

const (
Expand All @@ -17,17 +19,14 @@ const (
// WaitForTCP waits until a TCP connection can be established.
func WaitForTCP(t *testing.T, addr string) {
t.Helper()
deadline := time.Now().Add(defaultReadinessTimeout)

for time.Now().Before(deadline) {
require.Eventuallyf(t, func() bool {
conn, err := net.DialTimeout("tcp", addr, defaultReadinessInterval)
if err == nil {
conn.Close()
return
return true
}
time.Sleep(defaultReadinessInterval)
}
t.Fatalf("timeout waiting for TCP readiness at %s", addr)
return false
}, defaultReadinessTimeout, defaultReadinessInterval, "timeout waiting for TCP readiness at %s", addr)
}

// WaitForSpanFlush waits for spans to be flushed to collector.
Expand Down
Loading