chore(benchmark): use bare metal runners#477
Conversation
|
|
|
Wouldn't this be running for every PR? |
No, codespeed job just runs on master after PR merge. From otel docs:
Let's wait until these issues (open-telemetry/community#3427 and open-telemetry/community#3402) are resolved before merging this PR. I've moved the PR to DRAFT until issues are resolved. |
|
Ok, well you can assign me this 3247 |
|
@rovertrack I dont have privs on that repo for assigning issues. I guess it will be assigned to the responsible for executing that issue. |
|
Ok then I'm gonna ask in that issue section to assign me |
|
@rovertrack could you provide a comparison between current and bare-metal runners? We should ensure they work before merging + waiting times (related to open-telemetry/community#3402) + expected Rel. Std. Dev diff. |
updating you in some time! |
|
If we go with bare-metals, lets move codspeed to run daily, not per merge in master. There are some discussions ongoing between OTEL mantainers about limiting or refactoring how the bare-metal instance is used. |
|
The latest commit is for runner comparison if you approve the workflow on this PR I can give you the comparison diff. |
Ubuntu-latest benchstat artifact |
|
Nice, those are great results! Aligned with the expected values The PR should be mergeable after removing the comparison job and setting codspeed as a daily run. Don't forget to remove the other comment #477 (comment) |
|
@txabman42 removed the comparison job and making it ready for review! |
|
@txabman42 i have made it to run daily |
Description
Improved codespeed to use bare metal runners
Motivation
Fixes #467
Checklist
make formatmake lintmake test