Skip to content

chore(benchmark): use bare metal runners#477

Open
rovertrack wants to merge 2 commits into
open-telemetry:mainfrom
rovertrack:benchmark1
Open

chore(benchmark): use bare metal runners#477
rovertrack wants to merge 2 commits into
open-telemetry:mainfrom
rovertrack:benchmark1

Conversation

@rovertrack
Copy link
Copy Markdown

Description

Improved codespeed to use bare metal runners

Motivation

Fixes #467


Checklist

  • PR title follows conventional commits format
  • Code formatted: make format
  • Linters pass: make lint
  • Tests pass: make test
  • Tests added for new functionality
  • Tests follow testing guidelines
  • Documentation updated (if applicable)

@rovertrack rovertrack requested a review from a team as a code owner May 8, 2026 19:36
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 8, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: rovertrack / name: Rover track (6b032be)

@github-actions github-actions Bot added the scope:chore Something that needs to be taken care of but not very appealing label May 8, 2026
@rovertrack
Copy link
Copy Markdown
Author

runs-on: ubuntu-latest # TODO: oracle-bare-metal-64cpu-1024gb-x86-64-ubuntu-24

Wouldn't this be running for every PR?

@y1yang0 y1yang0 requested a review from txabman42 May 9, 2026 02:10
Comment thread .github/workflows/benchmark.yaml
@txabman42 txabman42 marked this pull request as draft May 11, 2026 12:33
@txabman42
Copy link
Copy Markdown
Contributor

Wouldn't this be running for every PR?

No, codespeed job just runs on master after PR merge.

From otel docs:

Access to bare metal runners for benchmarking is available to repositories on request (open a community issue)

Let's wait until these issues (open-telemetry/community#3427 and open-telemetry/community#3402) are resolved before merging this PR.

I've moved the PR to DRAFT until issues are resolved.

@rovertrack
Copy link
Copy Markdown
Author

Ok, well you can assign me this 3247
As it's still unassigned!

@txabman42
Copy link
Copy Markdown
Contributor

txabman42 commented May 11, 2026

@rovertrack I dont have privs on that repo for assigning issues. I guess it will be assigned to the responsible for executing that issue.

@rovertrack
Copy link
Copy Markdown
Author

Ok then I'm gonna ask in that issue section to assign me
Thanks.

@rovertrack
Copy link
Copy Markdown
Author

@txabman42 comment

@txabman42
Copy link
Copy Markdown
Contributor

@rovertrack could you provide a comparison between current and bare-metal runners? We should ensure they work before merging + waiting times (related to open-telemetry/community#3402) + expected Rel. Std. Dev diff.

@rovertrack
Copy link
Copy Markdown
Author

could you provide a comparison between current and bare-metal runners? We should ensure they work before merging + waiting times (related to open-telemetry/community#3402) + expected Rel. Std. Dev diff.

updating you in some time!

@txabman42
Copy link
Copy Markdown
Contributor

If we go with bare-metals, lets move codspeed to run daily, not per merge in master. There are some discussions ongoing between OTEL mantainers about limiting or refactoring how the bare-metal instance is used.

@rovertrack
Copy link
Copy Markdown
Author

rovertrack commented May 14, 2026

The latest commit is for runner comparison if you approve the workflow on this PR I can give you the comparison diff.

@rovertrack
Copy link
Copy Markdown
Author

Case ubuntu-latest Bare-Metal Runner Improvements
Queue Wait Time ~4 seconds ~23.5 minutes
baseline/otelc (R.S.D) 1% 1% Identical
multi/otelc (R.S.D) 2% 1% +1% Stability
largeidle/otelc (R.S.D) 5% 1% +4% Stability
largeidle/plain (R.S.D) 4% 1% +3% Stability

Ubuntu-latest benchstat artifact
Bare metal runner benchstat artifact

@txabman42
Copy link
Copy Markdown
Contributor

Nice, those are great results! Aligned with the expected values

The PR should be mergeable after removing the comparison job and setting codspeed as a daily run.

Don't forget to remove the other comment #477 (comment)

@rovertrack rovertrack marked this pull request as ready for review May 15, 2026 12:06
@rovertrack
Copy link
Copy Markdown
Author

@txabman42 removed the comparison job and making it ready for review!

Comment thread .github/workflows/benchmark.yaml Outdated
@rovertrack
Copy link
Copy Markdown
Author

@txabman42 i have made it to run daily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:chore Something that needs to be taken care of but not very appealing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Benchmark tests on bare metal runners

2 participants