fix(tool): otelc setup command failing to run#468
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
- Coverage 62.73% 62.71% -0.02%
==========================================
Files 62 62
Lines 4760 4758 -2
==========================================
- Hits 2986 2984 -2
+ Misses 1529 1528 -1
- Partials 245 246 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 62.73% 63.13% +0.40%
==========================================
Files 62 62
Lines 4760 4763 +3
==========================================
+ Hits 2986 3007 +21
+ Misses 1529 1509 -20
- Partials 245 247 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
txabman42
left a comment
There was a problem hiding this comment.
Nice PR! TY for the fix ❤️
Just some minor nitpicks
Co-authored-by: Xabier Martinez <39015378+txabman42@users.noreply.github.com>
Description
Fixes
otelc setupcommand failing to run.Also allows passing
build,installorgoas package names togetBuildPackagesfunction.Motivation
Currently running otelc setup command fails because
setupPhase.listBuildPlan()expects arguments asgo build ...:Also, passing "build", "install" or "go" as package names to
getBuildPackagesskips them as the loop breaks and it fallbacks to.as the default.Checklist
make formatmake lintmake test