Skip to content

Fixes #688: Change service.instance.id serialization to string #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Annosha wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Fixes #688: Change service.instance.id serialization to string #793

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a28238d
Fix: Change service.instance.id serialization to string
Annosha Oct 25, 2024
c4b26ce
Fix: use appropriate binary conversion for service.instance.id
Annosha Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/opentelemetry/src/otel_resource_detector.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ add_service_instance(Resource) ->
case erlang:node() of
nonode@nohost ->
ServiceInstanceId = otel_id_generator:generate_trace_id(),
ServiceInstanceResource = otel_resource:create([{'service.instance.id', ServiceInstanceId}]),
ServiceInstanceResource = otel_resource:create([{'service.instance.id', unicode:characters_to_binary(ServiceInstanceId)}]),
Comment thread
Annosha marked this conversation as resolved.
Outdated
otel_resource:merge(ServiceInstanceResource, Resource);
ServiceInstance ->
ServiceInstance1 = erlang:atom_to_binary(ServiceInstance, utf8),
Expand All @@ -290,7 +290,7 @@ add_service_instance(Resource) ->
end;
ServiceInstance ->
ServiceInstanceResource = otel_resource:create([{'service.instance.id',
otel_utils:assert_to_binary(ServiceInstance)}]),
unicode:characters_to_binary(ServiceInstance)}]),
Comment thread
Annosha marked this conversation as resolved.
Outdated
otel_resource:merge(ServiceInstanceResource, Resource)
end.

Expand Down