feat(opentelemetry_grpc): add initial setup for opentelemetry_grpc#554
Merged
Conversation
yordis
force-pushed
the
yordis/add-grpc
branch
from
7a1f888 to
e82f17e
Compare
sleipnir
suggested changes
Oct 3, 2025
yordis
force-pushed
the
yordis/add-grpc
branch
10 times, most recently
from
2f685df to
396975f
Compare
yordis
force-pushed
the
yordis/add-grpc
branch
8 times, most recently
from
1cb549c to
14faa20
Compare
|
@yordis I'm not a maintainer of this project, but PR looks good to me |
yordis
force-pushed
the
yordis/add-grpc
branch
4 times, most recently
from
d553114 to
173ba90
Compare
yordis
force-pushed
the
yordis/add-grpc
branch
8 times, most recently
from
a5e534a to
df85958
Compare
yordis
force-pushed
the
yordis/add-grpc
branch
3 times, most recently
from
478b5db to
e2ee9e2
Compare
|
Hi @tsloughter let me ask you. Can we move forward with this PR here in opentelemetry-erlang-contrib? |
@tsloughter can we make progress here? |
Member
Author
|
@tsloughter @sleipnir should we move this package under the elixir-grpc org? |
|
I first wanted to understand if there is any impediment here, let's wait a little longer for the @tsloughter to respond |
tsloughter
reviewed
Oct 27, 2025
yordis
force-pushed
the
yordis/add-grpc
branch
from
e2ee9e2 to
0eb2cde
Compare
tsloughter
reviewed
Oct 28, 2025
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/add-grpc
branch
from
0eb2cde to
3aafb3d
Compare
tsloughter
approved these changes
Oct 28, 2025
|
Thank you guys @tsloughter @yordis |
6 tasks
grzuy
reviewed
Mar 12, 2026
| ) do | ||
| span_ctx = OpentelemetryTelemetry.set_current_telemetry_span(@grpc_client_tracer_id, metadata) | ||
|
|
||
| OpenTelemetry.Span.record_exception(span_ctx, kind, reason, stacktrace) |
Contributor
There was a problem hiding this comment.
I don't think this function call would work?
We will need something like this in opentelemetry_api for it to work I think open-telemetry/opentelemetry-erlang#965.
| def handle_event([:grpc, :server, :rpc, :exception], _measurements, metadata, _config) do | ||
| ctx = OpentelemetryTelemetry.set_current_telemetry_span(@grpc_server_tracer_id, metadata) | ||
|
|
||
| OpenTelemetry.Span.record_exception(ctx, metadata.kind, metadata.reason, metadata.stacktrace) |
Member
Author
|
@grzuy please create a PR ... I am losing track of notifications. You could replicate the issue in the unit test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yordis Prieto yordis.prieto@gmail.com