fix: stop spin button at exclusive bound#491
Open
suhr25 wants to merge 3 commits into
Open
Conversation
Use only inclusive minimum/maximum for the HTML min/max attributes. Exclusive bounds are already enforced by validateField; passing them as the HTML attribute made the spin button stop at a value that validation then rejected. Signed-off-by: Suhrid Marwah <suhridmarwah07@gmail.com>
✅ Deploy Preview for otel-ecosystem-explorer canceled.
|
Contributor
Author
|
Hi @vitorvasc @jaydeluca, |
Signed-off-by: Suhrid Marwah <suhridmarwah07@gmail.com>
Member
|
@suhr25 can you provide steps on how to reproduce this issue? For example, which input do you see this problem occurring on? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes an issue where
NumberInputControltreatedexclusiveMinimum/exclusiveMaximumas HTMLmin/maxvalues. This caused the spin button to stop at values that were actually invalid and immediately failed validation.FIX
Updated
NumberInputControlto only use inclusiveminimumandmaximumvalues for the HTML input attributes. Since HTML number inputs treatminandmaxas inclusive bounds, using exclusive schema constraints was misleading the UI and allowing users to land on invalid values like0for fields that must be greater than0. Added a regression test to ensure exclusive-only constraints no longer set HTMLmin/maxattributes.CHECKLIST
NumberInputControl