Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 14 additions & 36 deletions ecosystem-explorer/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,11 @@ const HomePage = lazy(() =>
const JavaAgentPage = lazy(() =>
import("@/features/java-agent/java-agent-page").then((m) => ({ default: m.JavaAgentPage }))
);
const CollectorPage = lazy(() =>
import("@/features/collector/collector-page").then((m) => ({ default: m.CollectorPage }))
const CollectorPage = lazy(() => import("@/features/collector/collector-page"));
const CollectorComponentsPage = lazy(() =>
import("@/features/collector/collector-components-page").then((m) => ({
default: m.CollectorComponentsPage,
}))
);
const CollectorDetailPage = lazy(() =>
import("@/features/collector/collector-detail-page").then((m) => ({
Expand Down Expand Up @@ -91,40 +94,15 @@ export default function App() {
path="/java-agent/instrumentation"
element={<JavaInstrumentationListPage />}
/>
Comment thread
vitorvasc marked this conversation as resolved.
Outdated
<Route
path="/java-agent/instrumentation/:version"
element={<JavaInstrumentationListPage />}
/>
<Route
path="/java-agent/instrumentation/:version/:name"
element={<InstrumentationDetailPage />}
/>
<Route path="/java-agent/configuration" element={<JavaConfigurationListPage />} />
{isEnabled("JAVA_RELEASE_COMPARISON") && (
<Route path="/java-agent/releases" element={<JavaReleaseComparisonPage />} />
)}
{isEnabled("JAVA_CONFIG_BUILDER") && (
<Route
path="/java-agent/configuration/builder"
element={<ConfigurationBuilderPage />}
/>
)}
<Route path="/collector" element={<CollectorPage />} />
{isEnabled("COLLECTOR_PAGE") && (
<>
<Route path="/collector/components" element={<CollectorPage />} />
<Route path="/collector/components/:version" element={<CollectorPage />} />
<Route
path="/collector/components/:version/:id"
element={<CollectorDetailPage />}
/>
</>
)}
<Route path="/about" element={<AboutPage />} />
<Route path="*" element={<NotFoundPage />} />
</Routes>
</Suspense>
</ErrorBoundary>
)}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray )} with no matching opening, looks like a leftover from removing the {isEnabled("JAVA_CONFIG_BUILDER") && ( block. Either drop this line or restore the gated block above it.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this out while resolving the merge conflicts. Fixed it.

<Route path="/collector" element={<CollectorPage />} />
<Route path="/collector/components" element={<CollectorComponentsPage />} />
<Route path="/collector/components/:version" element={<CollectorComponentsPage />} />
<Route path="/collector/components/:version/:id" element={<CollectorDetailPage />} />
<Route path="/about" element={<AboutPage />} />
<Route path="*" element={<NotFoundPage />} />
</Routes>
</Suspense>
Comment thread
vitorvasc marked this conversation as resolved.
Outdated
</main>
<Footer />
</div>
Expand Down
Loading