[processor/tailsampling] Add feature gate to default ottl_condition error_mode to ignore#48438
Closed
highlyavailable wants to merge 1 commit into
Closed
Conversation
…rror_mode to ignore The ottl_condition policy's error_mode defaults to propagate, which can drop otherwise valid data when an OTTL condition fails to evaluate. This adds the processor.tailsamplingprocessor.errormodeignore feature gate. When enabled, an unset error_mode defaults to ignore, so condition errors are logged and processing continues. The gate is alpha and off by default, so current behavior is unchanged, and an explicitly configured error_mode always takes precedence.
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
|
github-actions
Bot
added
first-time contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ottl_conditionpolicy'serror_modedefaults topropagate, which can drop otherwise valid data when an OTTL condition fails to evaluate. This adds theprocessor.tailsamplingprocessor.errormodeignorefeature gate as the first step toward defaulting that toignore, where condition errors are logged and processing continues.The gate is
alphaand off by default, so nothing changes for users yet. When it is enabled, an unseterror_modedefaults toignore. Anerror_modeset explicitly in a policy always takes precedence over the gate.Link to tracking issue
Fixes #48420
Testing
Added a unit test covering both gate states. The existing processor test suite passes.
Documentation
Added a README section, a
documentation.mdfeature gate row, and a changelog entry.