[exporter/prometheusremotewrite] 5xx errors incorrectly classified as error_permanent="true"#48432
Open
bogdan-st wants to merge 1 commit into
Open
Conversation
43aaf3c to
f051a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
execute()had an unconditionalreturn consumererror.NewPermanent(err)that overrode the error classification already set byexecuteFunc, which correctly returns plain errors for 5xx and permanent errors for 4xx. On top of that,handleRequests()wrapped every error fromexecute()in anotherconsumererror.NewPermanent, unlikehandleRequestsV2()which propagates errors as-is. Both cause 5xx responses to appear aserror_permanent="true"onotelcol_exporter_send_failed_metric_points_total, making the attribute useless for distinguishing backend failures from data errors.Link to tracking issue
Fixes #48431
Testing
Added two cases to
TestRetriescoveringexecute()directly: 5xx with retry disabled returns a non-permanent error, 4xx still returns permanent.