Skip to content

[chore] (exporter/awsemfexporter) migrate feature gates to metadata.yaml #48428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agarvin-nr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[chore] (exporter/awsemfexporter) migrate feature gates to metadata.yaml #48428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa77aba
[chore] (exporter/awsemfexporter) migrate feature gates to metadata.yaml
agarvin-nr May 15, 2026
622caaa
chore: remove linting exclusion for manual feature gates
agarvin-nr May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,6 @@ linters:
- linters:
- forbidigo
path: connector/servicegraphconnector/
- linters:
- forbidigo
path: exporter/awsemfexporter/
- linters:
- forbidigo
path: exporter/awsxrayexporter/
Expand Down
13 changes: 13 additions & 0 deletions exporter/awsemfexporter/documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
[comment]: <> (Code generated by mdatagen. DO NOT EDIT.)

# awsemf

## Feature Gates

This component has the following feature gates:

| Feature Gate | Stage | Description | From Version | To Version | Reference |
| ------------ | ----- | ----------- | ------------ | ---------- | --------- |
| `awsemf.nodimrollupdefault` | alpha | Changes the default AWS EMF Exporter Dimension rollup option to NoDimensionRollup | v0.83.0 | N/A | [Link](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/23997) |

For more information about feature gates, see the [Feature Gates](https://github.com/open-telemetry/opentelemetry-collector/blob/main/featuregate/README.md) documentation.
8 changes: 1 addition & 7 deletions exporter/awsemfexporter/factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,13 @@ import (
"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/exporter"
"go.opentelemetry.io/collector/exporter/exporterhelper"
"go.opentelemetry.io/collector/featuregate"
"go.uber.org/zap"

"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awsemfexporter/internal/metadata"
"github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/awsutil"
"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/resourcetotelemetry"
)

var defaultNoRollupfg = featuregate.GlobalRegistry().MustRegister("awsemf.nodimrollupdefault", featuregate.StageAlpha,
featuregate.WithRegisterFromVersion("v0.83.0"),
featuregate.WithRegisterDescription("Changes the default AWS EMF Exporter Dimension rollup option to "+
"NoDimensionRollup"))

// NewFactory creates a factory for AWS EMF exporter.
func NewFactory() exporter.Factory {
return exporter.NewFactory(
Expand All @@ -33,7 +27,7 @@ func NewFactory() exporter.Factory {
// CreateDefaultConfig creates the default configuration for exporter.
func createDefaultConfig() component.Config {
var defaultDimensionRollupOption string
if defaultNoRollupfg.IsEnabled() {
if metadata.AwsemfNodimrollupdefaultFeatureGate.IsEnabled() {
defaultDimensionRollupOption = "NoDimensionRollup"
} else {
defaultDimensionRollupOption = "ZeroAndSingleDimensionRollup"
Expand Down
15 changes: 15 additions & 0 deletions exporter/awsemfexporter/internal/metadata/generated_feature_gates.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions exporter/awsemfexporter/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ status:
active: [Aneurysm9, mxiamxia]
emeritus: [shaochengwang, bryan-aguilar]

feature_gates:
- id: "awsemf.nodimrollupdefault"
description: Changes the default AWS EMF Exporter Dimension rollup option to NoDimensionRollup
stage: alpha
from_version: v0.83.0
reference_url: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/23997

tests:
config:
region: 'us-west-2'
Expand Down
Loading