Skip to content

internal/aws: re-enable k8s shutdown test#48427

Draft
MukundaKatta wants to merge 1 commit into
open-telemetry:mainfrom
MukundaKatta:codex/fix-k8sclient-shutdown-test
Draft

internal/aws: re-enable k8s shutdown test#48427
MukundaKatta wants to merge 1 commit into
open-telemetry:mainfrom
MukundaKatta:codex/fix-k8sclient-shutdown-test

Conversation

@MukundaKatta
Copy link
Copy Markdown

Description

Re-enable TestGetShutdown by closing the temporary kubeconfig file handle immediately after creating it. Leaving the handle open can prevent Windows cleanup from removing the temp file after the test starts Kubernetes informers.

Fixes #43918

Link to tracking issue

Fixes #43918

Testing

  • go test ./k8sclient from internal/aws/k8s
  • git diff --check

Documentation

No documentation changes required.

@MukundaKatta MukundaKatta requested a review from a team as a code owner May 15, 2026 20:29
@MukundaKatta MukundaKatta requested a review from ChrsMark May 15, 2026 20:29
@github-actions github-actions Bot added the first-time contributor PRs made by new contributors label May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

  • Read our Contributing Guidelines.
  • Sign the CLA if you haven't already.
  • First-time contributors should have at most one PR not marked as draft until their first PR is merged.
  • If your change isn't one of our priority components, reviews may take more time.
  • Give reviewers at least a few days before pinging them for feedback.
  • If you need help or struggle to move your PR forward, raise the topic on #otel-collector-dev or a Collector SIG meeting.

@github-actions github-actions Bot requested review from Aneurysm9 and mxiamxia May 15, 2026 20:29
@MukundaKatta MukundaKatta marked this pull request as draft May 15, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-time contributor PRs made by new contributors internal/aws

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aws/k8s] TestGetShutdown is failing on Windows after upgrading k8s library to 1.34

2 participants