[signaltometricsconnector] Add gate for default error_mode ignore

connector/signaltometricsconnector/README.md

@@ -93,7 +93,7 @@ signal_to_metrics:
 The `error_mode` configuration option determines how the connector handles errors that occur while processing OTTL expressions:
 
 - `error_mode` (optional): Determines how errors returned from OTTL expressions are handled. Valid values are `propagate`, `ignore`, and `silent`.
-  - `propagate` (default): Errors cause the entire batch to fail and be returned up the pipeline. This will result in the payload being dropped from the collector.
+  - `propagate` (default): Errors cause the entire batch to fail and be returned up the pipeline. This will result in the payload being dropped from the collector. The default will change to `ignore` when the `connector.signaltometrics.defaultErrorModeIgnore` feature gate is stable.
   - `ignore`: Errors are logged and the specific record that caused the error is skipped, but processing continues for the rest of the batch.
   - `silent`: Errors are not logged and the specific record that caused the error is skipped, but processing continues for the rest of the batch.
 

connector/signaltometricsconnector/config/config.go

@@ -61,7 +61,8 @@ type Config struct {
 	// If an error occurs, the record is skipped and the error is logged.
 	// `silent` means the connector ignores errors returned by conditions and continues processing.
 	// If an error occurs, the record is skipped and the error is not logged.
-	// The default value is `propagate`.
+	// The current default value is `propagate`, which will change to `ignore` when the
+	// `connector.signaltometrics.defaultErrorModeIgnore` feature gate is stable.
 	ErrorMode ottl.ErrorMode `mapstructure:"error_mode"`
 	// prevent unkeyed literal initialization
 	_ struct{}

connector/signaltometricsconnector/config/config.schema.yaml

@@ -20,7 +20,7 @@ $defs:
         items:
           $ref: metric_info
       error_mode:
-        description: ErrorMode determines how the connector reacts to errors that occur while processing an OTTL condition or statement during runtime data consumption. This setting does NOT affect errors during OTTL statement parsing at configuration time - those will always cause startup failures. Valid values are `propagate`, `ignore`, and `silent`. `propagate` means the connector returns the error up the pipeline. This will result in the payload being dropped from the collector. `ignore` means the connector ignores errors returned by conditions and continues processing. If an error occurs, the record is skipped and the error is logged. `silent` means the connector ignores errors returned by conditions and continues processing. If an error occurs, the record is skipped and the error is not logged. The default value is `propagate`.
+        description: ErrorMode determines how the connector reacts to errors that occur while processing an OTTL condition or statement during runtime data consumption. This setting does NOT affect errors during OTTL statement parsing at configuration time - those will always cause startup failures. Valid values are `propagate`, `ignore`, and `silent`. `propagate` means the connector returns the error up the pipeline. This will result in the payload being dropped from the collector. `ignore` means the connector ignores errors returned by conditions and continues processing. If an error occurs, the record is skipped and the error is logged. `silent` means the connector ignores errors returned by conditions and continues processing. If an error occurs, the record is skipped and the error is not logged. The current default value is `propagate`, which will change to `ignore` when the `connector.signaltometrics.defaultErrorModeIgnore` feature gate is stable.
         $ref: /pkg/ottl.error_mode
       logs:
         type: array

connector/signaltometricsconnector/factory.go

@@ -38,8 +38,12 @@ func NewFactory() connector.Factory {
 }
 
 func createDefaultConfig() component.Config {
+	defaultErrorMode := ottl.PropagateError
+	if metadata.ConnectorSignaltometricsDefaultErrorModeIgnoreFeatureGate.IsEnabled() {
+		defaultErrorMode = ottl.IgnoreError
+	}
 	return &config.Config{
-		ErrorMode: ottl.PropagateError,
+		ErrorMode: defaultErrorMode,
 	}
 }
 

connector/signaltometricsconnector/factory_test.go

@@ -11,11 +11,29 @@ import (
 	"go.opentelemetry.io/collector/connector/connectortest"
 	"go.opentelemetry.io/collector/connector/xconnector"
 	"go.opentelemetry.io/collector/consumer"
+	"go.opentelemetry.io/collector/featuregate"
 	"go.opentelemetry.io/collector/pdata/pmetric"
 
+	"github.com/open-telemetry/opentelemetry-collector-contrib/connector/signaltometricsconnector/config"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/connector/signaltometricsconnector/internal/metadata"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl"
 )
 
+func TestFactoryCreateDefaultConfig(t *testing.T) {
+	t.Cleanup(func() {
+		_ = featuregate.GlobalRegistry().Set(metadata.ConnectorSignaltometricsDefaultErrorModeIgnoreFeatureGate.ID(), false)
+	})
+
+	factory := NewFactory()
+	cfg := factory.CreateDefaultConfig()
+	require.Equal(t, ottl.PropagateError, cfg.(*config.Config).ErrorMode)
+
+	require.NoError(t, featuregate.GlobalRegistry().Set(metadata.ConnectorSignaltometricsDefaultErrorModeIgnoreFeatureGate.ID(), true))
+
+	cfg = factory.CreateDefaultConfig()
+	require.Equal(t, ottl.IgnoreError, cfg.(*config.Config).ErrorMode)
+}
+
 func TestNewFactoryWithLogs(t *testing.T) {
 	for _, tc := range []struct {
 		name string

connector/signaltometricsconnector/metadata.yaml

@@ -40,3 +40,10 @@ tests:
         description: "Count of datapoint"
         sum:
           value: Int(1) # Count each data point as 1, can also use the Int converter
+
+feature_gates:
+  - id: "connector.signaltometrics.defaultErrorModeIgnore"
+    description: Changes the default error_mode of the signaltometrics connector from propagate to ignore
+    stage: alpha
+    from_version: v0.153.0
+    reference_url: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/48419