Add attributes to AgentConfigFile#329
Open
owais wants to merge 1 commit into
Open
Conversation
Adds optional per-config-file key/value attributes so agents can report arbitrary metadata alongside each config body and content type. Fixes open-telemetry#328
tigrannajaryan
requested changes
May 12, 2026
Member
tigrannajaryan
left a comment
tigrannajaryan
left a comment
There was a problem hiding this comment.
@owais and I discussed this in a call. Blocking for now while he is exploring an alternate option.
Contributor
Any details why an alternative approach is needed? I was also thinking about the same approach. Vendor's spec can define the actual attributes while this spec is dynamic for everything. |
Member
Alternative does not require any changes to opamp spec. It works with opamp as is, as it was intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional per-config-file key/value attributes so agents can report arbitrary metadata alongside each config body and content type.
Fixes #328