test: isolate rerun-failures state file under tmpdir#63449
Open
atlowChemi wants to merge 1 commit into
Open
Conversation
The rerun-failures state file lived at a fixed path under fixtures/, so concurrent invocations of test-runner-test-rerun-failures (e.g. `python tools/test.py --repeat 100 -j 16 ...`) raced on a single file and failed intermittently. Move the path to `tmpdir.resolve(...)` so each process gets its own scratch state. Signed-off-by: atlowChemi <chemi@atlow.co.il>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MoLow
approved these changes
May 20, 2026
aduh95
approved these changes
May 20, 2026
aduh95
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63449 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 714 714
Lines 225918 225918
Branches 42735 42731 -4
=======================================
+ Hits 203471 203480 +9
+ Misses 14232 14222 -10
- Partials 8215 8216 +1 🚀 New features to boost your workflow:
|
Collaborator
atlowChemi
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #63431 I noticed that running
python tools/test.py --repeat 100 -j 10 "test/parallel/test-runner-test-rerun-failures"would keep failing since we saved all tests on to the same single JSON file.This change fixes the issue by writing the stats file onto tmpdir instead.