Skip to content

build,win: fix VS2022 arm64 PGO build#63413

Open
StefanStojanovic wants to merge 1 commit into
nodejs:mainfrom
JaneaSystems:mefi-pgo-vs2022-arm64-fix
Open

build,win: fix VS2022 arm64 PGO build#63413
StefanStojanovic wants to merge 1 commit into
nodejs:mainfrom
JaneaSystems:mefi-pgo-vs2022-arm64-fix

Conversation

@StefanStojanovic
Copy link
Copy Markdown
Contributor

My initial development for enabling PGO was done on a machine with Visual Studio 2026, where the code that landed works. However, it doesn't work with Visual Studio 2022 when cross-compiling for ARM64, because the clang_rt.profile.lib for ARM64 is distributed under a different location in VS2022. This fix adds a fallback that ensures the needed lib is found when compiling with VS 2022 (our release configuration).

Refs: #62761

Refs: nodejs#62761
Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
@StefanStojanovic StefanStojanovic added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels May 18, 2026
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 18, 2026
@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2026
@StefanStojanovic
Copy link
Copy Markdown
Contributor Author

Can someone from @nodejs/platform-windows please review and approve this? It is a simple fix for PGO, which is not even used in the CI, and I need it to test PGO possibilities in the release CI. That is where I caught the error, as my initial development was done in VS2026 locally, and our CI machines use VS2022.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 20, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@StefanStojanovic StefanStojanovic added the commit-queue Add this label to land a pull request using GitHub Actions. label May 21, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 21, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/63413
✔  Done loading data for nodejs/node/pull/63413
----------------------------------- PR info ------------------------------------
Title      build,win: fix VS2022 arm64 PGO build (#63413)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     StefanStojanovic:mefi-pgo-vs2022-arm64-fix -> nodejs:main
Labels     windows, build, needs-ci
Commits    1
 - build,win: fix VS2022 arm64 PGO build
Committers 1
 - StefanStojanovic <stefan.stojanovic@janeasystems.com>
PR-URL: https://github.com/nodejs/node/pull/63413
Refs: https://github.com/nodejs/node/pull/62761
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63413
Refs: https://github.com/nodejs/node/pull/62761
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 18 May 2026 14:43:43 GMT
   ✔  Approvals: 1
   ✔  - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/63413#pullrequestreview-4330607508
   ✘  This PR needs to wait 105 more hours to land (or 0 minutes if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-05-21T05:08:00Z: https://ci.nodejs.org/job/node-test-pull-request/73592/
- Querying data for job/node-test-pull-request/73592/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/26209495744

@StefanStojanovic StefanStojanovic removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants