[ci] introduce uv to accelerate pip install#9297
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
c7da135 to
acba889
Compare
|
@gemini review |
There was a problem hiding this comment.
Code Review
This pull request transitions the CI environment from standard pip to uv for faster package installation. The changes involve updating .dev_scripts/ci_container_test.sh to use uv pip install and modifying .dev_scripts/dockerci.sh to pass relevant UV_ environment variables into the test containers. Feedback suggests providing default values for UV_INDEX_URL and UV_SYSTEM_PYTHON to ensure the script remains functional and performant, as well as using a mirror for the initial uv installation to avoid potential network issues during bootstrapping.
67ffc6c to
c288af0
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request transitions the CI environment to use uv for dependency management, replacing standard pip commands and adding relevant UV_* environment variables to the Docker configuration. The reviewer provided several actionable suggestions to optimize the setup, including combining multiple uv pip install commands to reduce overhead, using a mirror for the uv installation, and correcting a hardcoded debug flag that could lead to unnecessary re-installations during release image testing.
d92ab66 to
cd4eec1
Compare
|
Hello, what is the purpose of this PR? |
cd4eec1 to
f48f1c1
Compare
Using UV installation as a replacement for the traditional pip installation can accelerate the installation process and achieve a certain effect. However, the CI (Continuous Integration) has been failing, making it difficult to see the specific improvement effects, then I am not sure if this replacement work for ms-swift. For reference, you can...sgl-project/sgl-kernel-npu#465 |
f48f1c1 to
912be6c
Compare
PR type
PR information
Integrate uv to significantly accelerate pip install in CI workflows. Replace
pip installwithuv pip installinlint.yamlandpublish.yaml.Changes
lint.yaml—pip install pre-commit→pip install uv + uv pip install pre-commitpublish.yaml—pip install wheel/twine/...→uv pip installwithpip install uvaddedFiles not modified (no pip install calls):
citest.yaml— pip install happens inside docker containercitest_npu.yaml— pip install happens inside docker containerExperiment results
N/A — CI infrastructure change only. Effect can be verified by comparing workflow run durations.