Skip to content

WIP: tests: use onebranch amd64 runner for go build tasks #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bfjelds wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: tests: use onebranch amd64 runner for go build tasks #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pipelines/templates/stages/azl_installer/build-installer-tools.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ stages:
timeoutInMinutes: 60
pool:
type: linux
name: trident-ubuntu-1es-pool-eastus2
hostArchitecture: amd64
# name: trident-ubuntu-1es-pool-eastus2
# hostArchitecture: amd64

variables:
ob_outputDirectory: /tmp/installer-tools
Expand Down
4 changes: 2 additions & 2 deletions .pipelines/templates/stages/building_tools/building-tools.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ stages:
pool:
${{ if eq(parameters.architecture, 'amd64') }}:
type: linux
name: trident-ubuntu-1es-pool-eastus2
hostArchitecture: amd64
# name: trident-ubuntu-1es-pool-eastus2
# hostArchitecture: amd64
${{ if eq(parameters.architecture, 'arm64') }}:
type: linux
name: azl3-hci-ARM64-1es-pool-westcentralus
Expand Down
13 changes: 11 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,14 +500,23 @@ bin/liveinstaller: \
$(INSTALLER_DIR)/go.sum
@mkdir -p bin
cd $(INSTALLER_DIR)/liveinstaller && \
CGO_ENABLED=0 go build -o $(CURDIR)/$(INSTALLER_OUT_DIR)/liveinstaller
if cat /etc/os-release | grep -i azurelinux >/dev/null 2>&1; then \
GOEXPERIMENT=ms_nocgo_opensslcrypto go build -o $(CURDIR)/$(INSTALLER_OUT_DIR)/liveinstaller; \
else \
CGO_ENABLED=0 go build -o $(CURDIR)/$(INSTALLER_OUT_DIR)/liveinstaller; \
fi
Comment on lines +503 to +507
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OS detection pipeline uses cat /etc/os-release | grep ... but only redirects grep’s output; if /etc/os-release is missing (e.g., non-Linux dev env), cat will still emit an error to stderr, adding noisy/confusing output to this target.
Suggestion: avoid cat and run grep directly against the file (and/or redirect file-read errors) so the check is quiet when the file doesn’t exist.

Copilot uses AI. Check for mistakes.

bin/attendedinstaller-simulator: \
$(shell find $(INSTALLER_DIR)/imagegen/ -type f) \
$(INSTALLER_DIR)/go.sum
@mkdir -p bin
cd $(INSTALLER_DIR)/imagegen/attendedinstaller/attendedinstaller_tests && \
CGO_ENABLED=0 go build -o $(CURDIR)/$(INSTALLER_OUT_DIR)/attendedinstaller-simulator attendedinstaller_simulator.go
if cat /etc/os-release | grep -i azurelinux >/dev/null 2>&1; then \
GOEXPERIMENT=ms_nocgo_opensslcrypto go build -o $(CURDIR)/$(INSTALLER_OUT_DIR)/attendedinstaller-simulator attendedinstaller_simulator.go; \
else \
CGO_ENABLED=0 go build -o $(CURDIR)/$(INSTALLER_OUT_DIR)/attendedinstaller-simulator attendedinstaller_simulator.go; \
fi
Comment on lines +514 to +518
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as above: the /etc/os-release check will still print cat errors to stderr if the file is absent because only grep output is redirected.
Suggestion: use grep -qi ... /etc/os-release 2>/dev/null (or similar) to keep this check quiet outside Azure Linux.

Copilot uses AI. Check for mistakes.


Comment on lines +519 to 520
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s trailing whitespace / an extra blank indented line here, which can create noisy diffs and fails some whitespace linters.
Suggestion: remove the trailing tab/whitespace on this blank line.

Suggested change

Copilot uses AI. Check for mistakes.
.PHONY: run-attendedinstaller-simulator
run-attendedinstaller-simulator: bin/attendedinstaller-simulator
Expand Down
Loading