fix(kf6-karchive) remove password protected files from source tarball#17295
Open
anphel31 wants to merge 1 commit into
Open
fix(kf6-karchive) remove password protected files from source tarball#17295anphel31 wants to merge 1 commit into
anphel31 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the kf6-karchive component to use a deterministically repacked upstream karchive-6.23.0.tar.xz with a password-protected test fixture removed, allowing the SRPM to pass the AZL RPM-signing (ESRP) scanning pipeline while keeping the produced RPMs functionally unchanged.
Changes:
- Add a
kf6-karchivededicated component definition that replaces upstreamSource0with a modified tarball hosted in the lookaside underpkgs_modified/. - Add a deterministic
modify_source.shhelper script to stripautotests/data/password_protected.7zand repack byte-identically. - Regenerate rendered outputs (
sources,.spec) and refresh the component lock fingerprint.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/kf6-karchive/modify_source.sh |
New deterministic strip-and-repack helper to remove the password-protected fixture and produce a reproducible tarball + SHA512. |
base/comps/kf6-karchive/kf6-karchive.comp.toml |
Defines a source-files replacement for upstream karchive-6.23.0.tar.xz pointing at the repacked lookaside blob with justification. |
base/comps/components.toml |
Removes the inline kf6-karchive entry and leaves a pointer to the new dedicated component file. |
specs/k/kf6-karchive/sources |
Updates Source0 SHA512 to match the repacked tarball. |
specs/k/kf6-karchive/kf6-karchive.spec |
Regenerated rendered spec with an rpmautospec Release bump only. |
locks/kf6-karchive.lock |
Updates the component input fingerprint after the component definition change. |
christopherco
approved these changes
May 16, 2026
christopherco
requested changes
May 16, 2026
f803ed0 to
74049ca
Compare
…arball Remove files autotests/data/zip64_extra_zip64_size_first.zip.gz and password_protected.7z from the source tarball. Karchive autotests are not built or run in our spec (no %check, BUILD_TESTING is off), so stripping these test fixtures is functionally inert.
1c7ef69 to
0346cf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove files
autotests/data/zip64_extra_zip64_size_first.zip.gzandpassword_protected.7zfrom the source tarball.The autotests are not built or run in our spec:
%checkblock.BUILD_TESTING=ON, which we don't set.Stripping the fixture is functionally inert; the published RPMs are unchanged.
Fixes: AB#19875
Modified-tarball SHA-512
Reproducible by anyone with the same upstream input — re-run
bash base/comps/kf6-karchive/modify_source.shto verify.Validation
STATUS: ok).origin.urireferences.