Skip to content

fix(kf6-karchive) remove password protected files from source tarball#17295

Open
anphel31 wants to merge 1 commit into
4.0from
anphel/esrp-fix-kf6-karchive
Open

fix(kf6-karchive) remove password protected files from source tarball#17295
anphel31 wants to merge 1 commit into
4.0from
anphel/esrp-fix-kf6-karchive

Conversation

@anphel31
Copy link
Copy Markdown
Member

@anphel31 anphel31 commented May 15, 2026

Summary

Remove files autotests/data/zip64_extra_zip64_size_first.zip.gz and password_protected.7z from the source tarball.

The autotests are not built or run in our spec:

  • No %check block.
  • Upstream's CMake gates them on BUILD_TESTING=ON, which we don't set.

Stripping the fixture is functionally inert; the published RPMs are unchanged.

Fixes: AB#19875

Modified-tarball SHA-512

Reproducible by anyone with the same upstream input — re-run
bash base/comps/kf6-karchive/modify_source.sh to verify.

Validation

  • Render: clean (STATUS: ok).
  • Repack determinism: confirmed across two local runs (byte-identical output).
  • Modified tarball uploaded to the lookaside path the comp.toml origin.uri
    references.
  • Test build
  • GPG test signing confirmed

@anphel31 anphel31 marked this pull request as ready for review May 15, 2026 23:32
Copilot AI review requested due to automatic review settings May 15, 2026 23:32
@anphel31 anphel31 requested a review from christopherco as a code owner May 15, 2026 23:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the kf6-karchive component to use a deterministically repacked upstream karchive-6.23.0.tar.xz with a password-protected test fixture removed, allowing the SRPM to pass the AZL RPM-signing (ESRP) scanning pipeline while keeping the produced RPMs functionally unchanged.

Changes:

  • Add a kf6-karchive dedicated component definition that replaces upstream Source0 with a modified tarball hosted in the lookaside under pkgs_modified/.
  • Add a deterministic modify_source.sh helper script to strip autotests/data/password_protected.7z and repack byte-identically.
  • Regenerate rendered outputs (sources, .spec) and refresh the component lock fingerprint.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
base/comps/kf6-karchive/modify_source.sh New deterministic strip-and-repack helper to remove the password-protected fixture and produce a reproducible tarball + SHA512.
base/comps/kf6-karchive/kf6-karchive.comp.toml Defines a source-files replacement for upstream karchive-6.23.0.tar.xz pointing at the repacked lookaside blob with justification.
base/comps/components.toml Removes the inline kf6-karchive entry and leaves a pointer to the new dedicated component file.
specs/k/kf6-karchive/sources Updates Source0 SHA512 to match the repacked tarball.
specs/k/kf6-karchive/kf6-karchive.spec Regenerated rendered spec with an rpmautospec Release bump only.
locks/kf6-karchive.lock Updates the component input fingerprint after the component definition change.

Comment thread base/comps/components.toml Outdated
@anphel31 anphel31 force-pushed the anphel/esrp-fix-kf6-karchive branch from f803ed0 to 74049ca Compare May 17, 2026 19:20
…arball

Remove files autotests/data/zip64_extra_zip64_size_first.zip.gz and password_protected.7z from the source tarball.

Karchive autotests are not built or run in our spec (no %check, BUILD_TESTING is off), so stripping these test fixtures is functionally inert.
@anphel31 anphel31 force-pushed the anphel/esrp-fix-kf6-karchive branch from 1c7ef69 to 0346cf0 Compare May 19, 2026 05:54
@anphel31 anphel31 requested a review from christopherco May 19, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants