Skip to content

fix: Remove dav1d, rust-dav1d, rust-dav1d-sys from distro#17289

Merged
christopherco merged 3 commits into
4.0from
tvuong/fix/remove-dav1d
May 18, 2026
Merged

fix: Remove dav1d, rust-dav1d, rust-dav1d-sys from distro#17289
christopherco merged 3 commits into
4.0from
tvuong/fix/remove-dav1d

Conversation

@trungams
Copy link
Copy Markdown
Member

@trungams trungams commented May 15, 2026

Remove the dav1d AV1 decoder and its Rust bindings. Dependents updated:

  • libavif: switch from dav1d to aom decoder
  • librsvg2: disable AVIF support (already disabled for RHEL)

Resolves AB#19414
Resolves AB#19709

@trungams trungams changed the title fix(pkg): Remove dav1d, rust-dav1d, rust-dav1d-sys from distro fix: Remove dav1d, rust-dav1d, rust-dav1d-sys from distro May 15, 2026
@trungams trungams force-pushed the tvuong/fix/remove-dav1d branch from 202c087 to 41dc19b Compare May 15, 2026 23:57
@trungams trungams marked this pull request as ready for review May 16, 2026 00:00
Copilot AI review requested due to automatic review settings May 16, 2026 00:00
@trungams trungams changed the base branch from tomls/base/main to 4.0 May 16, 2026 00:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the dav1d AV1 decoder and its Rust bindings (rust-dav1d, rust-dav1d-sys) from the Azure Linux distro, and updates key dependents (libavif, librsvg2, rust-rav1e) to avoid relying on dav1d.

Changes:

  • Removed dav1d and Rust binding components/specs/locks/sources.
  • Updated libavif to disable the dav1d codec (aom remains enabled by default in the spec).
  • Updated librsvg2 to disable AVIF support and rust-rav1e to stop enabling dav1d-related build/test flags; added new component overlay files for these changes.

Reviewed changes

Copilot reviewed 14 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
specs/r/rust-rav1e/rust-rav1e.spec Drops decode_test_dav1d from build/install/test flags; bumps release/changelog.
specs/r/rust-dav1d/sources Removes rust-dav1d crate source entry (component removal).
specs/r/rust-dav1d/rust-dav1d.spec Removes rendered spec for rust-dav1d (component removal).
specs/r/rust-dav1d-sys/sources Removes rust-dav1d-sys crate source entry (component removal).
specs/r/rust-dav1d-sys/rust-dav1d-sys.spec Removes rendered spec for rust-dav1d-sys (component removal).
specs/l/librsvg2/librsvg2.spec Forces AVIF support disabled in meson args; bumps release/changelog.
specs/l/libavif/libavif.spec Removes dav1d BuildRequires and disables dav1d codec in CMake args; bumps release/changelog.
specs/d/dav1d/sources Removes dav1d source entry (component removal).
specs/d/dav1d/dav1d.spec Removes rendered spec for dav1d (component removal).
locks/rust-rav1e.lock Updates input fingerprint for updated component config/spec output.
locks/rust-dav1d.lock Removes lock for retired component.
locks/rust-dav1d-sys.lock Removes lock for retired component.
locks/librsvg2.lock Updates input fingerprint for updated component config/spec output.
locks/libavif.lock Updates input fingerprint for updated component config/spec output.
locks/dav1d.lock Removes lock for retired component.
base/comps/rust-rav1e/rust-rav1e.comp.toml Adds overlays to remove decode_test_dav1d from build/install/test/license steps.
base/comps/librsvg2/librsvg2.comp.toml Adds overlay to disable AVIF support unconditionally.
base/comps/libavif/libavif.comp.toml Adds overlays to disable dav1d codec and remove pkgconfig(dav1d) BuildRequires.
base/comps/components.toml Removes inline component entries for retired/now-customized components.
base/comps/components-publish-channels.toml Removes dav1d component and rust-rav1e dav1d-related feature RPMs from publish mapping.

Comment thread base/comps/librsvg2/librsvg2.comp.toml
Comment thread specs/r/rust-rav1e/rust-rav1e.spec Outdated
Comment thread base/comps/rust-rav1e/rust-rav1e.comp.toml Outdated
Comment thread base/comps/libavif/libavif.comp.toml
Comment thread base/comps/components-publish-channels.toml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 20 changed files in this pull request and generated 3 comments.

Comment thread base/comps/rust-rav1e/rust-rav1e.comp.toml Outdated
Comment thread specs/r/rust-rav1e/rust-rav1e.spec Outdated
Comment thread specs/l/libavif/libavif.spec
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 20 changed files in this pull request and generated no new comments.

Copy link
Copy Markdown
Collaborator

@christopherco christopherco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes themselves look good. Please break the changes into separate smaller commits:

  • libavif changes
  • librsvg2 changes
  • rust-rav1e changes
  • remove dav1d, rust-dav1d, rustdav1d-sys

Doing it this way will ensure the autochangelog render describes the alterations made to that specific package.

@trungams trungams force-pushed the tvuong/fix/remove-dav1d branch from a3868c3 to cd489f3 Compare May 16, 2026 07:31
@trungams trungams requested a review from christopherco May 16, 2026 19:33
Copy link
Copy Markdown
Collaborator

@christopherco christopherco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments! One minor remaining adjustment needed, then we should be good to merge.

Comment thread base/comps/components-publish-channels.toml
@trungams trungams force-pushed the tvuong/fix/remove-dav1d branch 2 times, most recently from 9f6f42a to 9446ac0 Compare May 18, 2026 02:51
trungams added 3 commits May 17, 2026 19:57
Disable dav1d decoder and remove its BuildRequires. The aom codec
(already enabled) provides equivalent AV1 decode support.

Move libavif from inline components.toml entry to dedicated comp.toml
with overlays.
Unconditionally disable AVIF in the meson build (was already disabled
for RHEL). AVIF-in-SVG is an extremely niche use case for a cloud distro.

Move librsvg2 from inline components.toml entry to dedicated comp.toml
with overlays.
Remove the dav1d AV1 decoder library and its Rust bindings from the
distro. All dependents have been updated in prior commits to no longer
reference dav1d.

Remove dav1d from components-publish-channels.toml base-packages.
@trungams trungams force-pushed the tvuong/fix/remove-dav1d branch from 9446ac0 to b9b442e Compare May 18, 2026 02:59
@christopherco christopherco merged commit c5d2822 into 4.0 May 18, 2026
11 checks passed
@christopherco christopherco deleted the tvuong/fix/remove-dav1d branch May 18, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants