[Work Item #19219] Resolved ptests failure in azcopy package#17225
Merged
Conversation
3ad45d9 to
04b7283
Compare
Contributor
Author
|
Buddy build has passed. |
Kanishk-Bansal
requested changes
May 15, 2026
Contributor
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
remove CGO_ENABLED=0
Contributor
Author
removed. |
Kanishk-Bansal
approved these changes
May 15, 2026
Contributor
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
similar changes already merged in 70e4aa0
Contributor
|
Buddy build after recent changes. |
kgodara912
approved these changes
May 19, 2026
Contributor
kgodara912
left a comment
There was a problem hiding this comment.
Buddy build is successful. Though there might exist a case when this module is compiled with older go version which may not support this goexperiment feature, but we haven't seen that yet. Buddy build is successful. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
This is to fix ptests failures in TLS handshake issue due to openssl for package azcopy
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology