Fix variable scope for latest MSBuild path#5559
Open
matt-edmondson wants to merge 2 commits into
Open
Conversation
Fixes microsoft#5558 by allowing the path of the latest installed msbuild version to persist outside of the function scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5558 by allowing the path of the latest installed msbuild version to persist outside of the function scope
Context
Issue #5558 - A variable inside a powershell function was incorrectly scoped, causing mutations to be lost at the end of the function, and the value in the parent scope to be stale.
Description
Provide a concise summary of the changes introduced in this PR.
Risk Assessment (Low / Medium / High)
Low
Unit Tests Added or Updated (Yes / No)
No
Additional Testing Performed
Confirmed fixed on live agents
Change Behind Feature Flag (Yes / No)
N/A
Tech Design / Approach
N/A
Documentation Changes Required (Yes/No)
N/A
Logging Added/Updated (Yes/No)
N/A
Telemetry Added/Updated (Yes/No)
N/A
Rollback Scenario and Process (Yes/No)
N/A
Dependency Impact Assessed and Regression Tested (Yes/No)
N/A