Skip to content

Reduce noise when using Node 20 for container startup #5506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baarde wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −8
Open

Reduce noise when using Node 20 for container startup #5506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e38530
Reduce noise when using Node 20 for container startup
baarde Mar 20, 2026
63be723
Align Node 24 container startup logging
baarde Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/Agent.Worker/ContainerOperationProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,16 +688,21 @@ string useDoubleQuotes(string value)
{
if (logLine.Contains(labelContainerStartupUsingNode24))
{
executionContext.Debug("Using Node 24 for container startup.");
containerStartupCompleted = true;
container.ResultNodePath = node24ContainerPath;
break;
}
else if (logLine.Contains(labelContainerStartupUsingNode20))
{
string warningMsg = useNode24ToStartContainer
? "Cannot run Node 24 in container. Falling back to Node 20 for container startup."
: "Using Node 20 for container startup.";
executionContext.Warning(warningMsg);
if (useNode24ToStartContainer)
{
executionContext.Warning("Cannot run Node 24 in container. Falling back to Node 20 for container startup.");
}
else
{
executionContext.Debug("Using Node 20 for container startup.");
}
containerStartupCompleted = true;
container.ResultNodePath = node20ContainerPath;
break;
Expand Down
12 changes: 8 additions & 4 deletions src/Agent.Worker/ContainerOperationProviderEnhanced.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,10 +802,14 @@ string useDoubleQuotes(string value)
}
else if (logLine.Contains(labelContainerStartupUsingNode20))
{
string warningMsg = useNode24ToStartContainer
? "Cannot run Node 24 in container. Falling back to Node 20 for container startup."
: "Using Node 20 for container startup.";
executionContext.Warning(warningMsg);
if (useNode24ToStartContainer)
{
executionContext.Warning("Cannot run Node 24 in container. Falling back to Node 20 for container startup.");
}
else
{
executionContext.Debug("Using Node 20 for container startup.");
}
containerStartupCompleted = true;
container.ResultNodePath = node20ContainerPath;
break;
Expand Down