chore: fixing daily ci#3878
Conversation
|
You can find the image built from this PR at Built from 14fe6ed |
- Define NIMBLE := $(HOME)/.nimble/bin/nimble and use it for `nimble lock` in the `update` target. On macOS, Xcode no longer ships GNU make and the `export PATH := $(HOME)/.nimble/bin:$(PATH)` directive isn't honored by BSD bmake, so `nimble lock` (the only nimble call directly in the parent recipe of `update`) couldn't find nimble after install-nimble. - Update `stew/results` imports to `results` in chat2.nim and 6 test files. stew 0.5.0 removed `stew/results.nim` (was a deprecated forwarding shim in 0.4.x). The `results` package is already a separate dependency, so this is the direct, correct import. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This PR may contain changes to configuration options of one of the apps. If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed. Please also make sure the label |
| license = "MIT or Apache License 2.0" | ||
|
|
||
| const RequiredNimVersion = "2.2.4" | ||
| const RequiredNimVersion = "2.2.10" |
There was a problem hiding this comment.
I think this is not needed yet.
First we will need to validate the build with new compiler on a know good version of master -> run complete tests on fleets and maybe DST. @Ivansete-status
There was a problem hiding this comment.
Yes exactly, we will stick to 2.2.4 for now ( cc @darshankabariya .)
| # NIM binary location | ||
| NIM_BINARY := $(shell which nim 2>/dev/null) | ||
| NPH := $(HOME)/.nimble/bin/nph | ||
| NIMBLE := $(HOME)/.nimble/bin/nimble |
There was a problem hiding this comment.
Is this applies to all ci run on all platform?
There was a problem hiding this comment.
I think it will work fine as long as the NIMBLE_DIR is not overridden, which is the case.
| "version": "2.2.10", | ||
| "vcsRevision": "9fe2137fa2f3f66cf5a44f357d461829ac9e20c4", |
There was a problem hiding this comment.
Same as above, we need to keep compiler version we know as producing good code.
There was a problem hiding this comment.
Yes indeed, not needed to change nimble.lock
NagyZoltanPeter
left a comment
NagyZoltanPeter
left a comment
There was a problem hiding this comment.
Added comment.
Why compiler version bump is needed to make ci happy?
Ivansete-status
left a comment
Ivansete-status
left a comment
There was a problem hiding this comment.
Thanks for the PR!, some comments so far
| # NIM binary location | ||
| NIM_BINARY := $(shell which nim 2>/dev/null) | ||
| NPH := $(HOME)/.nimble/bin/nph | ||
| NIMBLE := $(HOME)/.nimble/bin/nimble |
There was a problem hiding this comment.
I think it will work fine as long as the NIMBLE_DIR is not overridden, which is the case.
| "version": "2.2.10", | ||
| "vcsRevision": "9fe2137fa2f3f66cf5a44f357d461829ac9e20c4", |
There was a problem hiding this comment.
Yes indeed, not needed to change nimble.lock
| license = "MIT or Apache License 2.0" | ||
|
|
||
| const RequiredNimVersion = "2.2.4" | ||
| const RequiredNimVersion = "2.2.10" |
There was a problem hiding this comment.
Yes exactly, we will stick to 2.2.4 for now ( cc @darshankabariya .)
3 participants
close #3876