Skip to content

chore: windows ci failure #3836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
darshankabariya wants to merge 6 commits into
base: master
Choose a base branch
from
+14 −6
Draft

chore: windows ci failure #3836

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b92a0ef
feat: initial changes
darshankabariya Apr 28, 2026
a9f241e
feat: us prebuilt nimble to avoid koch
darshankabariya Apr 28, 2026
03239f3
feat: add timout
darshankabariya Apr 29, 2026
5e39e77
feat: give access local depeneency
darshankabariya Apr 29, 2026
3ee1a88
feat: revart chanegs and use nimbledeps path
darshankabariya Apr 29, 2026
2091f39
feat: attach path
darshankabariya Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/windows-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:

env:
MSYSTEM: MINGW64
NIMBLE_DIR: ${{ github.workspace }}/nimbledeps

steps:
- name: Checkout code
Expand Down Expand Up @@ -75,10 +76,16 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Install Nimble ${{ env.NIMBLE_VERSION }}
# Use the prebuilt Windows binary instead of `nimble install nimble@...`,
# which triggers a koch self-bootstrap that races Windows Defender on
# bin\nim.exe and fails with "Access is denied".
run: |
export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$PATH"
cd /tmp && nimble install "nimble@${{ env.NIMBLE_VERSION }}" -y
mkdir -p "$HOME/.nimble/bin"
curl -fsSL -o /tmp/nimble.zip \
"https://github.com/nim-lang/nimble/releases/download/v${{ env.NIMBLE_VERSION }}/nimble-windows_x64.zip"
unzip -o /tmp/nimble.zip -d "$HOME/.nimble/bin"
echo "$HOME/.nimble/bin" >> $GITHUB_PATH
"$HOME/.nimble/bin/nimble.exe" --version

- name: Patch nimble.lock for Windows nim checksum
# nimble.exe uses Windows Git (core.autocrlf=true by default), which converts LF→CRLF
Expand All @@ -91,7 +98,7 @@ jobs:
- name: Install nimble deps
if: steps.cache-nimbledeps.outputs.cache-hit != 'true'
run: |
export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH"
export PATH="$HOME/.nimble/bin:$GITHUB_WORKSPACE/.nim_runtime/bin:$PATH"
nimble setup --localdeps -y
make rebuild-nat-libs-nimbledeps CC=gcc
make rebuild-bearssl-nimbledeps CC=gcc
Expand All @@ -101,13 +108,14 @@ jobs:
run: mkdir -p tmp

- name: Building wakunode2.exe
timeout-minutes: 45
run: |
export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH"
export PATH="$HOME/.nimble/bin:$GITHUB_WORKSPACE/.nim_runtime/bin:$PATH"
make wakunode2 V=3 -j${{ env.NPROC }}

- name: Building libwaku.dll
run: |
export PATH="$GITHUB_WORKSPACE/.nim_runtime/bin:$HOME/.nimble/bin:$PATH"
export PATH="$HOME/.nimble/bin:$GITHUB_WORKSPACE/.nim_runtime/bin:$PATH"
make libwaku STATIC=0 V=1 -j

- name: Check Executable
Expand All @@ -123,4 +131,4 @@ jobs:
else
echo "Build failed: libwaku.dll not found"
exit 1
fi
fi
Loading