chore: Extend AutoSharding with capability to handle arbitrary set of shards#3719
Draft
NagyZoltanPeter wants to merge 1 commit into
Draft
chore: Extend AutoSharding with capability to handle arbitrary set of shards#3719NagyZoltanPeter wants to merge 1 commit into
NagyZoltanPeter wants to merge 1 commit into
Conversation
…, and enable using it with static sharded network configurations. This can fill the gap that new messaging API does not support static sharding at all, this enhacement let's such API just cooperate with any network shard configuration without compromising backward compatibility of kernel API.
|
You can find the image built from this PR at Built from 70084f2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As new SendAPI and LogosMessageDelivery API will not support former static sharding on API interface. I found this is a gap where such autosharding node cannot properly select shards on network configured to static sharding (like status fleets) with arbitrary shards (non consecutive sequence of shard numbering).
This extension allows autoshading mounted for both configuration, so enable using autosharding publishing (when no pubsubTopic is provided). It is achieved with selecting shard from the supported shards list by the hash calculated index.
This allows support for any kind of shard selected properly.
This change does not break any previous functionality.
Changes
Issue
#3432
#3709