start using orc as memory management mode#3692
Open
Ivansete-status wants to merge 1 commit into
Open
Conversation
Ivansete-status
requested review from
NagyZoltanPeter,
darshankabariya and
fcecin
|
You can find the image built from this PR at Built from ac79760 |
NagyZoltanPeter
approved these changes
Jan 23, 2026
Contributor
NagyZoltanPeter
left a comment
NagyZoltanPeter
left a comment
There was a problem hiding this comment.
I completely agree with this. Can we make our tests green somehow? I think that can give us some safety for this move.
Ivansete-status
force-pushed
the
use-orc
branch
from
e770228 to
f66f254
Compare
Ivansete-status
force-pushed
the
use-orc
branch
from
f66f254 to
87f9cee
Compare
Collaborator
Author
|
The tests are crashing do to that: nim-lang/Nim#25693 Is pretty easy to replicate the crash. Just run |
Collaborator
Author
|
We will invest time to fix that Nim crash around Y2026Q3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows a @NagyZoltanPeter's suggestion made in a meeting some time ago, to start using ORC.
Ref: https://nim-lang.org/blog/2020/10/15/introduction-to-arc-orc-in-nim.html
Issue