Feat/service incentivization poc#3601
Draft
Ivansete-status wants to merge 61 commits into
Draft
Conversation
…on' into feat/service-incentivization-poc
* chore: remove unnecessary comment * move reputation manager logic to peer manager * remove peer selection from lightpush client * chore: lint fix
…incentivization-poc
Contributor
|
AFAIU, this branch is not intended to be merged. The PoC was presented at the Townhall of 2025-08-08, and continues in the form of the incentivization MVP discussions. Can / should we close this issue? CC @jm-clius |
Contributor
|
Yes, I think we want to maintain the branch at least until we make progress with the MVP, but there's no need for an ongoing, open PR. If we want to keep the feature branches clean, a fork of the repo could also be considered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #3318
Original author: @s-tikhomirov
The original PR got abruptly closed after a deep cleanup and refactor applied by this on 2025-09-30
Description
This is a feature branch for the service incentivization POC, which includes eligibility and reputation systems integrated into Lightpush (v3) behind a feature flag.
A Lightpush client uses the reputation manager to keep track of peers it used previously to publish messages. Peers that had failed at publishing a message get assigned a negative reputation and will not be chosen for future requests. If, however, a neutral- or positive-reputation peer isn't selected by the peer manager after a maximum number of attempts (10), a negative-reputation peer is still used.
This is a countinuaton of #3166, #3264, #3293, and #3309 with associated deliverable logos-messaging/pm#245.
Changes