E2e s13 s16#183
Merged
Merged
Conversation
fbarbu15
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two scenario tests for the
send()path:xfail, blocked by #3887)Changes
test_send_errors_and_concurrency.pyAdds
TestS13RelayHardFailureWithoutFallback.A relay peer is connected so the publish gets past
NO_PEERS_TO_RELAYand reaches the relay processor, where an oversized payload makes the publish fail. No lightpush fallback is configured. Verifiessend()returnsOk(RequestId)followed by anErrorevent.test_send_lightpush_and_edge.pyAdds
TestS16LightpushPeerAppearsLater.The edge sender starts with no reachable delivery peer; a lightpush service is meant to appear during the retry window so a later retry delivers the message. Verifies
send()returnsOk(RequestId)followed eventually byPropagated.S16 is marked
xfail— see #3887 .related CI job