chore(service-disco): rename startDiscovering to registerInterest#46
Merged
Conversation
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the module’s service-discovery API naming with upstream nim-libp2p changes (register/unregister “interest” vs start/stop “discovering”), bumps the pinned nim-libp2p revision in the Nix flake, and temporarily disables Mix-related code paths due to missing C bindings.
Changes:
- Renamed service discovery methods and underlying C symbol calls:
*StartDiscovering/*StopDiscovering→*RegisterInterest/*UnregisterInterest. - Disabled Mix compilation/tests via CMake source list changes and
#if 0guards. - Updated
flake.lockto track a newer nim-libp2p revision.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
CMakeLists.txt |
Stops building src/mix.cpp in the main module. |
src/plugin.cpp |
Disables mount_mix configuration wiring behind #if 0. |
src/plugin.h |
Hides Mix options/APIs behind #if 0; renames service discovery API declarations. |
src/service_discovery.cpp |
Renames service discovery implementation and switches to new C symbols. |
examples/service_discovery.cpp |
Updates example to call discoRegisterInterest/discoUnregisterInterest. |
tests/CMakeLists.txt |
Removes Mix sources/tests from the integration test build. |
tests/integration_service_discovery.cpp |
Updates tests to use discoRegisterInterest. |
tests/sync.cpp |
Disables Mix sync tests via #if 0 block. |
flake.lock |
Bumps the locked nim-libp2p input revision/hash. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gmelodie
approved these changes
May 11, 2026
70c9d67 to
80355bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames service-discovery calls to match vacp2p/nim-libp2p#2441, and bumps the flake to current nim-libp2p master.
discoStartDiscovering→discoRegisterInterestdiscoStopDiscovering→discoUnregisterInterestMix disabled
vacp2p/nim-libp2p#2378 moved mix out of nim-libp2p. The cbind layer no longer exports
libp2p_mix_*/mount_mix/Libp2pMixReadBehavior/libp2p_curve25519_key_tetc.Mix code has been disabled, with the assumption that it should stay in this module and can be easily brought back once a new cbind is available.