pedersen tests nexus#5
Draft
jonesmarvin8 wants to merge 3 commits into
Draft
Conversation
Author
|
Pallas and Vesta tests both throws the following issue:
This issue occurs if the guest program is Nexus' default hello-world and the unused crate pasta_curves is included in guest's cargo. |
Author
|
Nullifier_test and ped_secp256k1_test throw 200+ errors. This appears to be based on how Nexus interprets rust code rather than the guest code itself. |
Author
|
This test could be dropped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Pedersen commitment checks to the RISC0:
TODO: