Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add Tinybird pipes for organization page #4128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat: add Tinybird pipes for organization page #4128
Changes from 11 commits
81767528d34ba278eea71908b547283716f85aed8184531dbfc1a7d1546d0615c0e982b387268221825b2cd89cba4d60caFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two heavy copy pipes share the same schedule
Low Severity
org_page_activities_timeseries_copy_pipeandorg_page_projects_copy_pipeboth useCOPY_SCHEDULE 30 1 * * *, meaning they run simultaneously at 01:30 UTC. The other two copy pipes are intentionally staggered (01:15 and 01:45), and the PR architecture notes mention offset scheduling to avoid resource contention. The projects copy pipe is especially heavy (multiple full scans with complex joins), so running another copy pipe concurrently is likely unintentional. The activities timeseries pipe likely belongs at a different offset (e.g.,00 2 * * *or similar).Additional Locations (1)
services/libs/tinybird/pipes/org_page_projects_copy_pipe.pipe#L171-L172Reviewed by Cursor Bugbot for commit a4d60ca. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Count path duplicates expensive cross-segment table scan
Medium Severity
When
count=true, theorg_page_contributors_leaderboardnode independently queriesactivityRelations_deduplicated_cleaned_bucket_unionfor the same count already computed (but unused) inorg_page_contributors_activity_aggregates. Unlikecontributors_leaderboard.pipewhich references the project-scopedactivities_filtered, this pipe scans the full unscoped cross-segment union (10-bucket UNION ALL) twice per request-time count call.Additional Locations (1)
services/libs/tinybird/pipes/org_page_contributors.pipe#L12-L27Reviewed by Cursor Bugbot for commit b387268. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domain()returns empty string for non-URL inputMedium Severity
The ClickHouse
domain()function expects a full URL with protocol (e.g.,https://example.com/path) and returns empty string for plain domain names. ThevaluefromorganizationIdentitieswithtype = 'primary-domain'likely stores a bare domain (e.g.,example.com) not a URL, sodomain(w.website)would always produce an empty string instead of the expected domain value.Additional Locations (1)
services/libs/tinybird/pipes/org_page_profile.pipe#L20-L21Reviewed by Cursor Bugbot for commit fc1a7d1. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.