Skip to content

fix(ui): consolidate double glow effect in kanvas pop-up #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rudra2637 wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −1
Open

fix(ui): consolidate double glow effect in kanvas pop-up #1042

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0523276
fix(ui): consolidate double glow effect in kanvas pop-up
Rudra2637 May 15, 2026
ecff7f6
refactor: use SCSS theme variable for popup glow styling
Rudra2637 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/scss/_kanvas-corner-popup.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
padding: 1rem;
border: 1px solid #00d3a9;
border-radius: 5%;
box-shadow: 0 0 42px rgba(0, 211, 169, 0.85), 0 0 80px rgba(0, 211, 169, 0.25);
box-shadow: 0 0 28px rgba(0, 211, 169, 0.55);
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and ensure consistency with the rest of the project, consider using the $primary variable instead of the hardcoded RGB values. This ensures that if the brand color changes, the glow effect will update automatically. Note that $primary is already used in lines 149 and 159.

Suggested change
box-shadow: 0 0 28px rgba(0, 211, 169, 0.55);
box-shadow: 0 0 28px rgba($primary, 0.55);

Copy link
Copy Markdown
Contributor

@icoderarely icoderarely May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take gemini's review into consideration and prolly use secondary over primary variable. scss supports this so makes it easier.

I tried it on my end and the results were almost identical for both primary and secondary, it comes down to you what you think suits better.
And even if there is a suggestion change by a member, you will just have to change the variable name there.

Copy link
Copy Markdown
Contributor Author

@Rudra2637 Rudra2637 May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will go with your suggested change. On my end, I was trying to consolidate the border and background glow effect, which is why I used that approach.


@media (max-width: 640px) {
padding: 0.8rem;
Expand Down
Loading