Revert "add skip_cloning to periodics which don't need source code" + "add extra_refs to every periodic job that doesn't have it"#37042
Open
pohly wants to merge 1 commit into
Open
Conversation
k8s-ci-robot
added
area/config
k8s-ci-robot
added
sig/storage
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
… "add extra_refs to every periodic job that doesn't have it" This reverts commits - 0712a63 "add extra_refs to every periodic job that doesn't have it" - 37c0d10 "add skip_cloning to periodics which don't need source code" Adding extra_refs was meant to add information about the branch and repo to the Pod labels. But that has side effects: - Causes extra work in all jobs for checking out source code. - Causes testgrid to show the checked out source code revision, which is not necessarily the same as the code under test. The second commit avoided the overhead, but then testgrid started showing e.g. "master" instead of some revision. Ultimately the right approach is to not use extra_ref (this PR) and add labels differently (in some future PR). In addition to the reverts above, some manual cleanup was also needed, like removing the TestReposBeingSet test.
pohly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commits
Adding extra_refs was meant to add information about the branch and repo to the Pod labels. But that has side effects:
The second commit avoided the overhead, but then testgrid started showing e.g. "master" instead of some revision. Ultimately the right approach is to not use extra_ref (this PR) and add labels differently (in some future PR).
In addition to the reverts above, some manual cleanup was also needed, like removing the TestReposBeingSet test.
/assign @BenTheElder
/cc @upodroid