Add presubmit job to kubernetes-sigs/node-readiness-controller

[vitorfloriano]

This PR adds a presubmit job for running tests to kubernetes-sigs/node-readiness-controller.

Follow-up to kubernetes-sigs/node-readiness-controller#210 (comment)

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vitorfloriano
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• config/jobs/kubernetes-sigs/node-readiness-controller/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vitorfloriano]

/cc @Priyankasaggu11929

[Priyankasaggu11929]

Thank you for the PR, @vitorfloriano.

Just left one inline comment, but otherwise it looks good to me. Thanks!

[Priyankasaggu11929]

let's also run the job for release-v* branches

[vitorfloriano]

Done!

[vitorfloriano]

Just one question: make test generates a cover.out artifact. Should I do something with it? Or is it picked-up somehow by the TestGrid?

[Priyankasaggu11929]

setting "decorate: true" inserts an env variable to the prow job container - $ARTIFACTS (usually pointing to /logs/artifacts/ path in the container)

so for cover.out or any other artifacts to show up in the Prow spyglass (prow.k8s.io) artifacts tab, copy/move these files to $ARTIFACTS directory path.

Prow sidecar component will pick up these files collected in $ARTIFACTS path and show them in Artifacts tab.

see for examples -
https://cs.k8s.io/?q=ARTIFACTS&i=nope&literal=nope&files=&excludeFiles=&repos=kubernetes/test-infra

and docs - https://docs.prow.k8s.io/docs/components/pod-utilities/

[vitorfloriano]

Changed. PTAL.

[Priyankasaggu11929]

@vitorfloriano, apologies for suggesting it in parts.

Since we're going to move/run all our test suites for NRC repo in Prow now, and all of those tests will have artifacts of interest, so, how about we make the change in the Makefile itself - https://github.com/kubernetes-sigs/node-readiness-controller/blob/2239ccef203f6be9af3209ae7b8d146b9fccfb55/Makefile

at the top of the makefile, define an env variable ARTIFACTS defaulting to path /logs/artifacts

And then in the test make target - we can capture the cover.out at path something like $ARTIFACTS/cover.out?

Same we can do for other tests as well as we move.

That way, we don't have to do this copy/pasting of each artifact file to ARTIFACTS here in the job definition.

WDYT?

[vitorfloriano]

@Priyankasaggu11929 no problem. I thought about that at first, but then I considered that the make targets could be run locally and then I thought it would be better to move the artifacts here in the prowjob only.

But agreed, outputting to /logs/artifacts/cover.out seems more elegant. I'll open a PR in a minute.