Skip to content

v1.36 windows jobs#37030

Open
marosset wants to merge 1 commit into
kubernetes:masterfrom
marosset:windows-1.36-jobs
Open

v1.36 windows jobs#37030
marosset wants to merge 1 commit into
kubernetes:masterfrom
marosset:windows-1.36-jobs

Conversation

@marosset
Copy link
Copy Markdown
Contributor

@marosset marosset commented May 13, 2026

Moves automatically added v1.36 sig windows jobs to be with the others and adds missing serial-slow and presubmit jobs

@k8s-ci-robot k8s-ci-robot requested a review from AnishShah May 13, 2026 21:38
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label May 13, 2026
@k8s-ci-robot k8s-ci-robot requested a review from claudiubelu May 13, 2026 21:38
@k8s-ci-robot k8s-ci-robot added area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/testgrid sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels May 13, 2026
@marosset
Copy link
Copy Markdown
Contributor Author

marosset commented May 13, 2026

/assign @zylxjtu

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2026
@marosset marosset force-pushed the windows-1.36-jobs branch from 31b9140 to 31017b3 Compare May 13, 2026 22:05
@zylxjtu
Copy link
Copy Markdown
Contributor

zylxjtu commented May 13, 2026

Do we still need to keep 1.33?

@zylxjtu
Copy link
Copy Markdown
Contributor

zylxjtu commented May 13, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marosset, zylxjtu
Once this PR has been reviewed and has the lgtm label, please assign verolop for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zylxjtu
zylxjtu reviewed May 13, 2026
View reviewed changes
Comment thread config/jobs/kubernetes-sigs/sig-windows/release-1.36-windows.yaml Outdated
Comment thread config/jobs/kubernetes/sig-release/release-branch-jobs/1.36.yaml
memory: 24Gi
securityContext:
privileged: true
- annotations:
Copy link
Copy Markdown
Contributor

@zylxjtu zylxjtu May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity: is this added by release team?

Copy link
Copy Markdown
Contributor Author

@marosset marosset May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'fork-per-release' annotations at

test-infra/config/jobs/kubernetes-sigs/sig-windows/release-master-windows.yaml

Lines 125 to 127 in befc6a5

annotations:
fork-per-release: "true"
fork-per-release-replacements: "KUBERNETES_VERSION=latest -> KUBERNETES_VERSION=latest-{{.Version}}"
cause the jobs to be created for each release

@marosset
v1.36 windows jobs
e826e1f 
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@marosset marosset force-pushed the windows-1.36-jobs branch from 31017b3 to e826e1f Compare May 14, 2026 17:58
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 14, 2026

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 15, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnishShah AnishShah Awaiting requested review from AnishShah

@claudiubelu claudiubelu Awaiting requested review from claudiubelu

1 more reviewer

@zylxjtu zylxjtu zylxjtu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@zylxjtu zylxjtu

Labels

area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marosset @zylxjtu @k8s-ci-robot