Skip to content

fix: remove unsafe exec() in bpf_d_path_tetragon.h #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: remove unsafe exec() in bpf_d_path_tetragon.h #3188

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3f8eef4
fix: V-001 security vulnerability
orbisai0security May 13, 2026
2a0ae4d
chore: regenerate BPF bytecode for memcpy bounds check fix
orbisai0security May 14, 2026
7c8401a
Apply code changes: > @orbisai0security Please could you regenerate t…
orbisai0security May 14, 2026
35bde76
Fix header and update ebpf bytecode
ccojocar May 14, 2026
c22cbcc
Apply code changes: @orbisai0security can you address code review com…
orbisai0security May 15, 2026
8e6c8ba
fix: correct indentation of *buflen line in prepend()
orbisai0security May 16, 2026
a54035b
chore: regenerate BPF bytecode after bounds check reordering
orbisai0security May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/pkg/daemon/bpfrecorder/bpf/bpf_d_path_tetragon.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ prepend(char **buffer, int *buflen, const char *str, int namelen)
if (*buflen < 0) // will never happen - check function comment
return -ENAMETOOLONG;
*buffer -= namelen;
if (namelen <= 0 || namelen > MAX_BUF_LEN)
Copy link
Copy Markdown
Contributor

@ccojocar ccojocar May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is call only with a fix length of 10. See

security-profiles-operator/internal/pkg/daemon/bpfrecorder/bpf/bpf_d_path_tetragon.h

Line 293 in c098a83

int error = prepend(buf, buflen, " (deleted)", 10);

Copy link
Copy Markdown
Contributor

@ccojocar ccojocar May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is not strictly required since this function is not exposed at the moment, but is a good defence in depth for future use.

Copy link
Copy Markdown

@anupamme anupamme May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orbisai0security can you address code review comments?

return -ENAMETOOLONG;
memcpy(*buffer, str, namelen);
return 0;
}
Expand Down
Binary file modified internal/pkg/daemon/bpfrecorder/bpf/recorder.bpf.o.amd64
View file
Open in desktop
Binary file not shown.
Binary file modified internal/pkg/daemon/bpfrecorder/bpf/recorder.bpf.o.arm64
View file
Open in desktop
Binary file not shown.
Binary file modified internal/pkg/daemon/enricher/auditsource/bpf/enricher.bpf.o.amd64
View file
Open in desktop
Binary file not shown.
Binary file modified internal/pkg/daemon/enricher/auditsource/bpf/enricher.bpf.o.arm64
View file
Open in desktop
Binary file not shown.
Loading