Add E2E tests for update and reconciliation scenarios#183
Open
aliok wants to merge 2 commits into
Open
Conversation
Signed-off-by: Ali Ok <aliok@redhat.com>
✅ Deploy Preview for mcp-lifecycle-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
There was a problem hiding this comment.
Pull request overview
This PR adds new end-to-end (E2E) coverage for MCPServer update flows and reconciliation/drift scenarios, expanding the validation of controller behavior against real Kubernetes resources.
Changes:
- Added a new E2E test suite covering spec updates (image, storage), drift correction (replicas, service port), deletion/recreation, owner references, cascading deletion, and config-hash rollout behavior.
- Extended the E2E MCPServer builder options with
WithReplicasto configure runtime replica count.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/e2e/reconciliation_test.go | Introduces new reconciliation/update E2E scenarios validating controller behavior across multiple drift and mutation cases. |
| test/e2e/framework/builders.go | Adds WithReplicas option for constructing MCPServer CRs with a desired replica count in E2E tests. |
Comments suppressed due to low confidence (1)
test/e2e/reconciliation_test.go:249
- This ranges over dep.Spec.Template.Spec.Containers[0].VolumeMounts without checking that the pod template has at least one container. A defensive len(dep.Spec.Template.Spec.Containers) check would prevent a panic and provide a clearer assertion failure.
for _, m := range dep.Spec.Template.Spec.Containers[0].VolumeMounts {
if m.MountPath == "/etc/remove-config" {
t.Fatal("volume mount at /etc/remove-config should have been removed")
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+80
to
+83
| actualImage := dep.Spec.Template.Spec.Containers[0].Image | ||
| if actualImage != digestRef { | ||
| t.Fatalf("expected image %q, got %q", digestRef, actualImage) | ||
| } |
| if !foundVolume { | ||
| t.Fatal("expected ConfigMap volume 'add-config' after storage addition") | ||
| } | ||
|
|
Comment on lines
+326
to
+329
| svc.Spec.Ports[0].Port = 9999 | ||
| if err := r.Update(ctx, svc); err != nil { | ||
| t.Fatalf("failed to change Service port: %v", err) | ||
| } |
Signed-off-by: Ali Ok <aliok@redhat.com>
| WithLabel("type", "reconciliation"). | ||
| WithLabel("scenario", "storage-add"). | ||
| Setup(func(ctx context.Context, t *testing.T, cfg *envconf.Config) context.Context { | ||
| ns := ctx.Value(f.NsKey).(string) |
Comment on lines
+274
to
+279
| feature := features.New("MCPServer replica drift correction"). | ||
| WithLabel("type", "reconciliation"). | ||
| WithLabel("scenario", "drift-replicas"). | ||
| Setup(func(ctx context.Context, t *testing.T, cfg *envconf.Config) context.Context { | ||
| return f.SetupMCPServer(ctx, t, cfg, "drift-repl", true) | ||
| }). |
Comment on lines
+598
to
+602
| } | ||
|
|
||
| hash := dep.Spec.Template.Annotations["mcp.x-k8s.io/config-hash"] | ||
| if hash == "" { | ||
| t.Fatal("expected config-hash annotation on pod template") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176
Add E2E tests for update and reconciliation scenarios