Reorganize jobframework package.#11217
Conversation
k8s-ci-robot
added
kind/cleanup
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
size/L
| const ( | ||
| StopReasonWorkloadDeleted StopReason = "WorkloadDeleted" | ||
| StopReasonWorkloadEvicted StopReason = "WorkloadEvicted" | ||
| StopReasonNoMatchingWorkload StopReason = "NoMatchingWorkload" | ||
| StopReasonNotAdmitted StopReason = "NotAdmitted" | ||
| ) |
There was a problem hiding this comment.
this could be a part of interface.go file
There was a problem hiding this comment.
but it's just my preference, ignore it if you like
There was a problem hiding this comment.
I’m trying to simplify this file and its structure to make it easier to understand which interfaces should be implemented externally. Right now it feels a bit messy.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 9758f972605408e2b5b2e7ca00bb1ec8c48c5b83 |
mbobrovskyi
force-pushed
the
cleanup/reorganize-jobframework
branch
from
66b4dbf to
198eb08
Compare
k8s-ci-robot
removed
the
lgtm
|
still re-organize, no functional changes 👍 |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: f3f92664a0fc5ad209b46ba5db9fd3b4af45e6ee |
| } | ||
|
|
||
| // WorkloadShouldBeSuspended determines whether jobObj should be default suspended on creation | ||
| func WorkloadShouldBeSuspended(ctx context.Context, jobObj client.Object, k8sClient client.Client, |
There was a problem hiding this comment.
Should we rename this file as workloads.go? It seems all the utils are related to workloads actually, wdyt?
mimowo
left a comment
mimowo
left a comment
There was a problem hiding this comment.
/approve
I skimmed the PR and it looks reasonable, the refactoring is in the right direction.
I left a comment about a possible follow up.
Promoting the lgtm from #11217 (comment)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 participants
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
Reorganize jobframework package.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?