doc: reorganize test documentation#11169
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| # Integration tests | ||
| make test-integration | ||
|
|
||
| # E2E: build image and run (Apple Silicon / arm64 — omit PLATFORM on amd64) |
There was a problem hiding this comment.
what does this mean: omit PLATFORM on amd64
There was a problem hiding this comment.
Thanks @amy ! The phrasing is ambiguous. The intent is: on an amd64 machine, PLATFORM=linux/arm64 is unnecessary because the default platform matches the host, so you just run make kind-image-build test-e2e-baseline without any prefix. The PLATFORM= prefix is only needed on Apple Silicon to cross-compile for linux/arm64. I'll clarify the comment in the doc.
|
LGTM! Besides the nit. Just confirming to whoever is reviewer for this that this is mostly just additive and any big red removal blocks were actually moved further down the doc. (But please address the nit) /lgtm |
|
LGTM label has been added. DetailsGit tree hash: e288f0baadbb0be9819bc38e353ea91f012687ee |
|
/assign @tenzen-y |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 8bc9a22b60584a9e0c9ef2cdd7eb6ee1bc2ff178 |
|
/approve |
|
@mimowo: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gyliu513, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mimowo: #11169 failed to apply on top of branch "website": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind documentation
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #11164
/cc @amy
Special notes for your reviewer:
Does this PR introduce a user-facing change?