Skip to content

doc: reorganize test documentation#11169

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
gyliu513:test
May 18, 2026
Merged

doc: reorganize test documentation#11169
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
gyliu513:test

Conversation

@gyliu513
Copy link
Copy Markdown
Member

/kind documentation

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #11164

/cc @amy

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot requested a review from amy May 13, 2026 18:11
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels May 13, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 13, 2026

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 7434538
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6a0b2a2ab7605a00086057c2
😎 Deploy Preview https://deploy-preview-11169--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2026
# Integration tests
make test-integration

# E2E: build image and run (Apple Silicon / arm64 — omit PLATFORM on amd64)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean: omit PLATFORM on amd64

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amy ! The phrasing is ambiguous. The intent is: on an amd64 machine, PLATFORM=linux/arm64 is unnecessary because the default platform matches the host, so you just run make kind-image-build test-e2e-baseline without any prefix. The PLATFORM= prefix is only needed on Apple Silicon to cross-compile for linux/arm64. I'll clarify the comment in the doc.

@amy
Copy link
Copy Markdown
Contributor

amy commented May 18, 2026

LGTM! Besides the nit. Just confirming to whoever is reviewer for this that this is mostly just additive and any big red removal blocks were actually moved further down the doc. (But please address the nit)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: e288f0baadbb0be9819bc38e353ea91f012687ee

@amy
Copy link
Copy Markdown
Contributor

amy commented May 18, 2026

/assign @tenzen-y

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2026
@k8s-ci-robot k8s-ci-robot requested review from amy and tenzen-y May 18, 2026 15:03
@amy
Copy link
Copy Markdown
Contributor

amy commented May 18, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 8bc9a22b60584a9e0c9ef2cdd7eb6ee1bc2ff178

@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented May 18, 2026

/approve
/cherrypick website
I checked the PR briefly, and it looks reasonable, promoting the lgtm from @amy. Thank you folks 👍

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of website in a new PR and assign it to you.

Details

In response to this:

/approve
/cherrypick website
I checked the PR briefly, and it looks reasonable, promoting the lgtm from @amy. Thank you folks 👍

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2026
@k8s-ci-robot k8s-ci-robot merged commit 4d65419 into kubernetes-sigs:main May 18, 2026
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.18 milestone May 18, 2026
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown
Contributor

@mimowo: #11169 failed to apply on top of branch "website":

Applying: doc: reorganize test documentation
Using index info to reconstruct a base tree...
M	site/content/en/docs/contribution_guidelines/testing.md
M	site/content/zh-CN/docs/contribution_guidelines/testing.md
Falling back to patching base and 3-way merge...
Auto-merging site/content/zh-CN/docs/contribution_guidelines/testing.md
CONFLICT (content): Merge conflict in site/content/zh-CN/docs/contribution_guidelines/testing.md
Auto-merging site/content/en/docs/contribution_guidelines/testing.md
CONFLICT (content): Merge conflict in site/content/en/docs/contribution_guidelines/testing.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 doc: reorganize test documentation

Details

In response to this:

/approve
/cherrypick website
I checked the PR briefly, and it looks reasonable, promoting the lgtm from @amy. Thank you folks 👍

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] reorganize the test documentation

6 participants