Skip to content

Replace injected Ansible fact variables in bootstrap_os role#13264

Open
NikKumar811 wants to merge 1 commit into
kubernetes-sigs:masterfrom
NikKumar811:fix-ansible-facts-bootstrap-os-clean
Open

Replace injected Ansible fact variables in bootstrap_os role#13264
NikKumar811 wants to merge 1 commit into
kubernetes-sigs:masterfrom
NikKumar811:fix-ansible-facts-bootstrap-os-clean

Conversation

@NikKumar811
Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR updates the bootstrap_os role to replace usage of injected Ansible fact variables (ansible_*) with ansible_facts[...]. This ensures compatibility with upcoming Ansible 2.24 changes, where fact injection will be disabled by default.

Which issue(s) this PR fixes:

Related to #13208

Special notes for your reviewer:

  • Changes are limited to the bootstrap_os role for focused review
  • No changes were made to hostvars, ansible_env, or set_fact usage
  • Existing logic and behavior are preserved
  • Roles reviewed with no required changes:
    - adduser
    - bastion-ssh-config
    - bootstrap-os

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 14, 2026
@k8s-ci-robot k8s-ci-robot requested review from cyclinder and mzaian May 14, 2026 19:10
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NikKumar811
Once this PR has been reviewed and has the lgtm label, please assign tico88612 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 14, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @NikKumar811. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 14, 2026
@NikKumar811 NikKumar811 force-pushed the fix-ansible-facts-bootstrap-os-clean branch from bacc51d to 327efc4 Compare May 14, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants