Skip to content

Remove deprecated apiserver-count kubeadm config option#13262

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
guoard:apiserver_count
May 18, 2026
Merged

Remove deprecated apiserver-count kubeadm config option#13262
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
guoard:apiserver_count

Conversation

@guoard
Copy link
Copy Markdown
Contributor

@guoard guoard commented May 14, 2026

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
When this option is present, the kube-apiserver logs the following deprecation warning:

Flag --apiserver-count has been deprecated, apiserver-count is deprecated and will be removed in a future version.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Ali Afsharzadeh <afsharzadeh8@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2026
@k8s-ci-robot k8s-ci-robot requested review from tico88612 and yankay May 14, 2026 16:02
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2026
@tico88612
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 18, 2026
Copy link
Copy Markdown
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes/kubernetes#119856

Remove this option is good from me, I don't think this will impact. (our endpoint-reconciler-type is lease, not master-count)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guoard, tico88612

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2026
@yankay
Copy link
Copy Markdown
Member

yankay commented May 18, 2026

Nice cleanup! The apiserver-count flag is only used by the deprecated master-count endpoint reconciler, and we're already using lease (the default) right below it. Safe to drop.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2026
@k8s-ci-robot k8s-ci-robot merged commit 17f2703 into kubernetes-sigs:master May 18, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants