Rename cilium certgen and envoy image variables#13260
Open
guoard wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ali Afsharzadeh <afsharzadeh8@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: guoard The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename hubble specific cilium image variables to more generic names:
cilium_hubble_certgen_image_repo→cilium_certgen_image_repocilium_hubble_certgen_image_tag→cilium_certgen_image_tagcilium_hubble_envoy_image_repo→cilium_envoy_image_repocilium_hubble_envoy_image_tag→cilium_envoy_image_tagWhat type of PR is this?
/kind cleanup
What this PR does / why we need it:
The previous variable names incorrectly implied that these images are
used exclusively by hubble.
certgenis also used by Cluster Meshenvoyis not only used for hubble. It is also required for L7 networkpolicy support and is deployed by default on new clusters.
This change makes the variable naming more accurate and aligns it with
their actual usage scope.
Does this PR introduce a user-facing change?: