Skip to content

fix(reset): add etcd backup directory cleanup to prevent redeployment failures #13221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Irshu786 wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −0
Open

fix(reset): add etcd backup directory cleanup to prevent redeployment failures #13221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
277ddb7
Add tasks to find and remove etcd backup directories
Irshu786 Apr 29, 2026
c58831a
fix: squash copilot commits
Irshu786 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roles/reset/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@
- /etc/origin/ovn
- "{{ sysctl_file_path }}"
- /etc/crictl.yaml
- "{{ etcd_backup_prefix }}"
Copy link
Copy Markdown
Contributor

@guoard guoard May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, this will fail because that variable is undefined when reset playbook is running.

and this is not a good idea to delete everything in /var/backups dir, we need to delete {{ etcd_backup_prefix }}/etcd-* files. but i don't know how to access that variable.

Copy link
Copy Markdown
Author

@Irshu786 Irshu786 May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a task rather than env approach?

Copy link
Copy Markdown
Contributor

@guoard guoard May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yankay WDYT?

Copy link
Copy Markdown
Author

@Irshu786 Irshu786 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yankay can u have a look 👁️

ignore_errors: true # noqa ignore-errors
tags:
- files
Expand Down