docs: note required CI before tagging in release process#13207
Open
yankay wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
k8s-ci-robot
added
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yankay The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XS
There was a problem hiding this comment.
Pull request overview
Updates the release process documentation to add an explicit gate ensuring required CI is green before creating a release tag, reducing the risk of tagging a bad commit.
Changes:
- Add a new step in
RELEASE.mdto verify required CI is green on the target commit before taggingvX.Y.Z.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 1. (Only for major releases) The `kube_version_min_required` variable is set to `n-1` | ||
| 1. (Only for major releases) Remove hashes for [EOL versions](https://github.com/kubernetes/website/blob/main/content/en/releases/patch-releases.md) of kubernetes from `*_checksums` variables. | ||
| 1. Create the release note with [Kubernetes Release Notes Generator](https://github.com/kubernetes/release/blob/master/cmd/release-notes/README.md). See the following `Release note creation` section for the details. | ||
| 1. Before tagging `vX.Y.Z`, ensure **required** CI is green on the target commit (e.g. Prow `/test all` on the release-prep PR, then confirm the branch after merge). |
Member
|
How could we check for this? Do we have a basis for doing this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add a single step to
RELEASE.md: before taggingvX.Y.Z, ensure required CI is green on the target commit (for example Prow/test allon the release-prep PR, then confirm the branch after merge).Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: