Update README.md of helm-apps role#13200
Conversation
Adding this role as documented results in the following error: The task includes an option with an undefined variable. The error was: 'download_run_once' is undefined This happens because helm-apps depends on the kubernetes-apps/helm role, which in turn expects variables provided by the kubespray_defaults role. When kubespray_defaults is not included in the play, required variables (such as download_run_once) are missing, causing the playbook to fail. This commit updates the role integration to ensure that kubespray_defaults is loaded before helm-apps, aligning the dependency order with what the upstream roles expect
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
Welcome @hatef94! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hatef94 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @hatef94. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest-failed |
|
@hatef94 Please rebase your branch on master. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
The current documentation instructs users to add the helm-apps role directly to their play. However, following the documented steps results in the following error during execution:
The task includes an option with an undefined variable. The error was: 'download_run_once' is undefinedThis happens because
helm-appsdepends on thekubernetes-apps/helmrole, which in turn expects variables provided by thekubespray_defaultsrole. Whenkubespray_defaultsis not included in the play, required variables (such asdownload_run_once) are missing, causing the playbook to fail.This commit updates the role integration to ensure that
kubespray_defaultsis loaded beforehelm-apps, aligning the dependency order with what the upstream roles expectWhich issue(s) this PR fixes:
Fixes #11345
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Update provided documentation of how to add helm applications to Kubernetes