Skip to content

Add Srishti-j18 as reviewer#13188

Open
Srishti-j18 wants to merge 2 commits into
kubernetes-sigs:masterfrom
Srishti-j18:add-owner-Srishti-j18
Open

Add Srishti-j18 as reviewer#13188
Srishti-j18 wants to merge 2 commits into
kubernetes-sigs:masterfrom
Srishti-j18:add-owner-Srishti-j18

Conversation

@Srishti-j18
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind flake

What this PR does / why we need it:
I'm currently a contributor in the LFX Mentorship program, and I'm thrilled to have been invited to serve as a reviewer for Kubespray.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copilot AI review requested due to automatic review settings April 16, 2026 09:32
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Srishti-j18
Once this PR has been reviewed and has the lgtm label, please assign mzaian for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from VannTen April 16, 2026 09:32
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2026
@k8s-ci-robot k8s-ci-robot requested a review from yankay April 16, 2026 09:32
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 16, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Srishti-j18. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s reviewer alias list to include a new Kubespray reviewer, aligning with the PR’s goal of onboarding an additional reviewer via Prow/GitHub OWNERS configuration.

Changes:

  • Added Srishti-j18 to the kubespray-reviewers alias in OWNERS_ALIASES.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread OWNERS_ALIASES
- cyclinder
- erikjiang
- mzaian
- Srishti-j18
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub usernames in this file are consistently lowercase; consider changing this entry to srishti-j18 to match the established convention and avoid any tooling that might treat the value case-sensitively.

Suggested change
- Srishti-j18
- srishti-j18

Copilot uses AI. Check for mistakes.
@Srishti-j18 Srishti-j18 force-pushed the add-owner-Srishti-j18 branch from 1f8564d to 62ffd01 Compare April 16, 2026 09:39
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 16, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 16, 2026
@Srishti-j18
Copy link
Copy Markdown
Contributor Author

Is the owner alias file case-sensitive? I changed Srishti-j18 to srishti-j18, but the bot marked me untrusted. I'm wondering why VannTen to vannten still works.

@tico88612
Copy link
Copy Markdown
Member

tico88612 commented Apr 22, 2026

@Srishti-j18 I guess you don't have Kubernetes member now, could you apply this in k/org first? and find your sponsors (at least 2)
I can sponsor this for you, but you need to ask another one.

@Srishti-j18
Copy link
Copy Markdown
Contributor Author

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants