WIP 🐛fix(alpha update): license boilerplate#5669
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR addresses alpha generate warnings during the internal update flow by preserving the existing license boilerplate (hack/boilerplate.go.txt) across the branch cleanup/regeneration cycle.
Changes:
- Preserve
hack/boilerplate.go.txtbefore cleanup and restore it before runningalpha generateduring both ancestor and upgrade branch preparation. - Add integration tests covering boilerplate preservation/restoration behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/cli/alpha/internal/update/update.go | Adds boilerplate preserve/restore helpers and wires them into ancestor/upgrade branch preparation. |
| internal/cli/alpha/internal/update/update_test.go | Adds integration tests validating boilerplate preservation and restore behavior. |
1771550 to
2c443c0
Compare
2c443c0 to
d49b8b4
Compare
|
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
When we run alpha generate, it warns because the license has not been used.
Problem
When I was testing it out I saw:
Example: https://github.com/camilamacedo86/test-operator/actions/runs/25160729772/job/73754189181
The file should be found.
So, this PR fix it for alpha generate.